Opened 9 years ago

Closed 9 years ago

#1647 closed Bug (fixed)

Selecting a Format while in a Bulleted/Numbered list fails to make new Bullets/Numbers

Reported by: jonbrooks Owned by: fredck
Priority: Normal Milestone: FCKeditor 2.6
Component: UI : Enter Key Version: SVN (FCKeditor) - Retired
Keywords: Confirmed Review+ Cc:

Description

This issue was related to bug 277 which is now fixed.

To Reproduce:

  • Create a Bulleted list
  • Select 'Heading 2'
  • Type some text, hit return

Result:

No new bullets appear. The only way to make new bullets is to position the cursor at the end of the document and create a new bulleted list.

Attachments (3)

1647.patch (1.7 KB) - added by martinkou 9 years ago.
1647_2.patch (2.0 KB) - added by martinkou 9 years ago.
1647_3.patch (11.1 KB) - added by fredck 9 years ago.

Download all attachments as: .zip

Change History (14)

comment:1 Changed 9 years ago by jonbrooks

Additionally, IE has unexpected cursor behavior with these steps:

  • Create a Bulleted List
  • Type one line of text, hit return
  • Select 'Heading 2'

Result: Cursor position jumps to the previous bullet.

comment:2 Changed 9 years ago by martinkou

  • Component changed from General to UI : Enter Key
  • Keywords Confirmed added
  • Milestone set to FCKeditor 2.6
  • Version set to SVN

Confirmed both bug reports.

comment:3 Changed 9 years ago by martinkou

  • Owner set to martinkou
  • Status changed from new to assigned

Changed 9 years ago by martinkou

comment:4 Changed 9 years ago by martinkou

  • Keywords Review? added

comment:5 Changed 9 years ago by fredck

  • Keywords Review- added; Review? removed

The proposed patch will give a strange effect when loading the following HTML:

<ul>
    <li>
    <h1>Hit ENTER HERE -&gt;&lt;--</h1>
    <p>Line 2</p>
    </li>
</ul>

Then, just hit ENTER in between the arrows.

comment:6 Changed 9 years ago by fredck

Maybe a simple solution for it would be using FCKDomTools.BreakParent() to split the <li> in that case.

Also, right after the proposed patch, there is a "if ( oSplitInfo )" check. Any manipulation using oSplitInfo should be done inside of it.

Changed 9 years ago by martinkou

comment:7 Changed 9 years ago by martinkou

  • Keywords Review? added; Review- removed

Updated patch according to Fred's suggestions.

comment:8 Changed 9 years ago by fredck

  • Keywords Review- added; Review? removed

The proposed patch would be ok (a line could be removed there), but it fails in the following test case (which should have been noted during the patch tests :P):

  1. Create a bulletted item.
  2. Set format to "Heading 1" to that item.
  3. Hit ENTER at the end of that item text.

In IE it throws and error... in FF it does strange things.

It is not any fault in the patch changes though. It is a bug in FCKDomTools.BreakParent. I'll propose a patch for it.

Changed 9 years ago by fredck

comment:9 Changed 9 years ago by fredck

  • Keywords Review? added; Review- removed
  • Owner changed from martinkou to fredck
  • Status changed from assigned to new

The proposed patch is much similar to the previous one developed by Martin, but it fixes FCKDomTools.BreakParent.

Actually the bug fells down to FCKW3CRange._ExecContentsAction. It was not working on cases where we have a range like the following (where [ and ] are the range boundaries):

<p><b>Test[</b>]</p>

It was considering the range empty in that case. I've written several tests that helped on properly fixing it.

I'm taking this ticket to myself, so it can be properly reviewed. The fixes proposed by Martin have Review+ for me, so just other things should be reviewed now.

comment:10 Changed 9 years ago by martinkou

  • Keywords Review+ added; Review? removed

comment:11 Changed 9 years ago by fredck

  • Resolution set to fixed
  • Status changed from new to closed

Fixed with [1714]. Click here for more info about our SVN system.

Note: See TracTickets for help on using tickets.
© 2003 – 2016 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy