Opened 8 years ago
Closed 8 years ago
#16705 closed Bug (fixed)
Unable to paste base64 images using Firefox 50.0
| Reported by: | Irina | Owned by: | kkrzton |
|---|---|---|---|
| Priority: | Nice to have (we want to work on it) | Milestone: | CKEditor 4.6.2 |
| Component: | General | Version: | 4.5.0 |
| Keywords: | Firefox IBM | Cc: | Satya Minnekanti |
Description
Steps to reproduce
- Open nightly sample (http://nightly.ckeditor.com/16-11-30-07-06/standard/samples/)
- Use Printsceen or Paint to paste image (Ctrl + V) into the editor
Expected result
base64 image pastes into the editor
Actual result
Other details (browser, OS, CKEditor version, installed plugins)
Firefox 50.0.x only
Change History (7)
comment:1 Changed 8 years ago by
| Keywords: | Firefox added |
|---|---|
| Status: | new → confirmed |
| Version: | 4.6.1 (GitHub - master) → 4.5.0 |
comment:2 Changed 8 years ago by
Just a suggestion: couldn't we simply get blob of the image and convert it to base64 with enhanced clipboard that was added in 4.5.0?
comment:3 Changed 8 years ago by
As m.lewandowski suggested it can be done by getting Blob of the image and then transforming it to base64. The pasted image is available in dataTransfer object (in files array) as an File (inheriting after Blob). To convert it to base64 one may use FileReader and its readAsDataUrl method.
Since we switched to custom clipboard handling in 4.5.0, it seems that case is not handled properly. The content of clipboard is not properly recognized by recogniseContentType method. Also it seems we are missing the proper flow for this particular case.
comment:4 Changed 8 years ago by
| Milestone: | → CKEditor 4.6.2 |
|---|---|
| Priority: | Normal → Nice to have (we want to work on it) |
comment:5 Changed 8 years ago by
| Owner: | set to kkrzton |
|---|---|
| Status: | confirmed → assigned |
comment:7 Changed 8 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | review → closed |
LGTM. Fixed with git:b941fec.
I have checked CKEditor 4.6 and FF 50.0.2 in deed it doesn't work but it seems that it is still possible to paste base64 images in CKEditor 4.4.8- and this feature got broken in CKEditor 4.5.0.
NOTE: IE11 seems to be working fine in all versions.