Opened 8 years ago
Closed 8 years ago
#16752 closed New Feature (fixed)
Add Azerbaijani localization
Reported by: | Anna Tomanek | Owned by: | Tade0 |
---|---|---|---|
Priority: | Nice to have (we want to work on it) | Milestone: | CKEditor 4.6.2 |
Component: | General | Version: | |
Keywords: | Cc: |
Description
Azerbaijani is 100% complete at Transifex, but so far it hasn't been added to CKEditor configuration.
Expected result
Azerbaijani should be added to CKEditor configuration to make it available to users.
Change History (14)
comment:1 Changed 8 years ago by
Status: | new → confirmed |
---|
comment:2 Changed 8 years ago by
Priority: | Must have (possibly next milestone) → Nice to have (we want to work on it) |
---|
comment:3 Changed 8 years ago by
Owner: | changed from Wiktor Walc to Tade0 |
---|---|
Status: | confirmed → assigned |
comment:4 Changed 8 years ago by
Status: | assigned → review |
---|
comment:5 Changed 8 years ago by
Status: | review → review_failed |
---|
After enabling AZ language in the editor, colorbutton and colordialog still don't seem to respect that setting and display everything in English – even while language files for these plugins are avalaible.
Labels for contextmenu iframe are also incorrectly bound.
Probably the same for docprops plugin.
comment:6 Changed 8 years ago by
Please add a manual test in this case for this language. Don't forget bender tags, so this manual test is used during the testing phase.
comment:7 Changed 8 years ago by
Maybe it would be better to create generic manual test for language integration, with an ability to switch between languages?
comment:8 Changed 8 years ago by
@t.jakut we have somethign like that in old samples: http://ckeditor.dev/samples/old/uilanguages.html
We could make a generic manual test out of it without any effort. So +1 for this idea.
comment:9 Changed 8 years ago by
There's one additional thing:
We don't have Azerbaijani translations for colours like "Light Grayish Cyan" or "Emerald" that were added during a recent palette update.
comment:10 Changed 8 years ago by
@Tade0 AFAICT: tx should automatically inline english translations there. We're ofc fine with that.
comment:11 Changed 8 years ago by
Status: | review_failed → review |
---|
In some plugins the language
property was not updated, fixed that.
Added manual test.
Changes pushed to branch:t/16752.
comment:12 Changed 8 years ago by
Status: | review → review_failed |
---|
- Opening manual test causes following exception:
Uncaught TypeError: Cannot read property 'icons' of null
at CKEDITOR.resourceManager.<anonymous> (plugins.js:39) at CKEDITOR.resourceManager.<anonymous> (resourcemanager.js:225) at doCallback (scriptloader.js:70) at checkLoaded (scriptloader.js:84) at loadScript (scriptloader.js:103) at Object.load (scriptloader.js:153) at CKEDITOR.resourceManager.load (resourcemanager.js:209) at CKEDITOR.resourceManager.loadPlugins (plugins.js:29) at CKEDITOR.resourceManager.load (plugins.js:88) at loadPlugins (editor.js:507)
And the mt is not working (its disabled).
- It was supposed to be a general manual test, so it should land in a proper directory, without
tc
tag. I'd suggest putting it astests/core/manual/language
. - This is not a Polish lang https://github.com/cksource/ckeditor-dev/blob/29618bb/lang/az.js#L7-L8
comment:13 Changed 8 years ago by
Status: | review_failed → review |
---|
Corrected errors, included the core plugin set in manual test, moved manual test to tests/core/language/manual
(last half of the name like that to stay consistent with other tests in that directory).
Changes pushed to branch:t/16752.
comment:14 Changed 8 years ago by
Resolution: | → fixed |
---|---|
Status: | review → closed |
This time looks OK, the only thing I'm missing here is entry in https://github.com/cksource/ckeditor-dev/blob/t/16752/lang/_translationstatus.txt#L17 but we can add it later.
Merged to master with git:5b0bded.
Added translations updated from transifex.
Note:
copyformatting
plugin needs a separate update, because there are translations for several languages that were added in the meantime.Left it alone for now to avoid making a mess.
Changes pushed to branch:t/16752.