Opened 2 weeks ago

Last modified 9 days ago

#16850 review New Feature

Context menu disable option

Reported by: m.lewandowski Owned by: Tade0
Priority: Normal Milestone: CKEditor 4.7.0
Component: General Version: 4.7.0 (GitHub - major)
Keywords: Cc:

Description (last modified by m.lewandowski)

We need an option to disable our custom context menu, even if the plugin is loaded. The thing is that contextmenu plugin is required by plugins like tabletools or liststyle, where it's the only way to see the features added by the plugin.

If we'd remove it from required property, this plugin would not be automatically picked by our online builder, so that's a no-go.

But some customers provide custom implementation of UI, where context menu is not needed.

Change History (6)

comment:1 Changed 2 weeks ago by m.lewandowski

  • Status changed from new to confirmed

comment:2 Changed 10 days ago by m.lewandowski

  • Description modified (diff)

comment:3 Changed 10 days ago by Tade0

  • Owner set to Tade0
  • Status changed from confirmed to assigned

comment:4 Changed 10 days ago by Tade0

  • Status changed from assigned to review

Added a configuration option that simply prevents the context menu from opening.

comment:5 Changed 9 days ago by t.jakut

  • Status changed from review to review_failed

Fix LGTM, however there's no unit test. It should be easy to write one (probably it would be enough to check if open calls menu's show method).

comment:6 Changed 9 days ago by Tade0

  • Status changed from review_failed to review

Added unit tests.

Changes pushed to branch:t/16850.

Note: See TracTickets for help on using tickets.
© 2003 – 2016 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy