Opened 3 months ago

Closed 2 months ago

#16920 closed Bug (fixed)

Several plugins not using dialog as a direct dependency

Reported by: m.lewandowski Owned by: k.krzton
Priority: Normal Milestone: CKEditor 4.7.0
Component: General Version: 4.7.0 (GitHub - major)
Keywords: Cc:

Description

Originally #16919 has shown that some widget plugins doesn't have dialog specified as a dependency, while directly calling dialog methods. It's an anti-pattern that we need to fix now, that we're removing dialog dependency from clipboard plugin.

So far aforementioned ticket fixes just one Embedbase plugin, but there are more that needs to be reviewed.

Change History (4)

comment:1 Changed 3 months ago by m.lewandowski

  • Status changed from new to confirmed

comment:2 Changed 3 months ago by k.krzton

  • Owner set to k.krzton
  • Status changed from confirmed to assigned

comment:3 Changed 3 months ago by k.krzton

  • Status changed from assigned to review

comment:4 Changed 2 months ago by m.lewandowski

  • Resolution set to fixed
  • Status changed from review to closed
  • Summary changed from Widget plugins not using dialog as a direct dependency to Several plugins not using dialog as a direct dependency
Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy