Opened 6 weeks ago

Closed 5 weeks ago

Last modified 4 weeks ago

#16971 closed New Feature (fixed)

tabletools should extract background color even for complex background value

Reported by: m.lewandowski Owned by:
Priority: Nice to have (we want to work on it) Milestone: CKEditor 4.7.0
Component: General Version:
Keywords: Cc:

Description (last modified by m.lewandowski)

Currently if td's background background property contains something more than just a color, it won't be recognized. We could improve it.

  1. Open CKEditor with tabletools plugin.
  2. Set the editor content using "Source" button to the following:
    <table border="1" cellpadding="1" cellspacing="1" style="width:500px">
    	<tbody>
    		<tr>
    			<td style="background:#00cc99 no-repeat center">&nbsp;</td>
    			<td>&nbsp;</td>
    		</tr>
    	</tbody>
    </table>
    
  3. Go back to wysiwyg mode.

Expected

First cell has a backgournd applied.

Actual

Color is stripped out by ACF.

Additional Notes

Recently we have added a more advanced function for parsing CSS background - CKEDITOR.tools.style.parse.background. We could use it to more reliably tell if property contains a color.

Rationale: It was needed during PR#337, where Firefox would put much more values into CSS prop ta

Change History (4)

comment:1 Changed 6 weeks ago by m.lewandowski

  • Status changed from new to confirmed

comment:2 Changed 6 weeks ago by m.lewandowski

  • Description modified (diff)

comment:3 Changed 5 weeks ago by k.krzton

  • Resolution set to fixed
  • Status changed from confirmed to closed

Merged to major with 84d3983.

comment:4 Changed 4 weeks ago by m.lewandowski

  • Description modified (diff)
  • Summary changed from tabletools should also retain color from background containing more than color to tabletools should extract background color even for complex background value
Note: See TracTickets for help on using tickets.
© 2003 – 2016 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy