Opened 9 years ago

Closed 8 years ago

Last modified 2 years ago

#1707 closed Bug (fixed)

IE : Loop while formatting Word pasted data

Reported by: oliveira_lcs Owned by: martinkou
Priority: High Milestone: FCKeditor 2.6
Component: Plugin : Paste from Word Version: FCKeditor 2.5
Keywords: IE Review+ Cc:

Description

Hi,

I´m getting this bug since release 2.5, aparentely due to a javascript loop on text format commands. The page freezes and returns a message asking me to stop the script that is taking too long to run. That also happens on the demo page for this site when you put a long text (it doesn´t need to be that long), containing paragraphs with different text formats, select it all and try to do any formatting with it, such as right aligning.

I´m using Internet Explorer 6.0 and Windows XP.

Hope you find a solution on that enableing me to upgrade FCKEditor, solving most of the problems I have on the previous versions.

Thanks,

Luís

Attachments (3)

bug_fckeditor.doc (179.5 KB) - added by oliveira_lcs 9 years ago.
Sample Data and Screenshot
1707.patch (1.0 KB) - added by martinkou 9 years ago.
Proposed patch for fixing #1707.
1707_2.patch (887 bytes) - added by martinkou 9 years ago.
Simplified patch for fixing #1707.

Download all attachments as: .zip

Change History (18)

Changed 9 years ago by oliveira_lcs

Sample Data and Screenshot

comment:1 Changed 9 years ago by fredck

  • Keywords Confirmed IE added
  • Milestone set to FCKeditor 2.6
  • Priority changed from Normal to High
  • Summary changed from PAGE FREEZES WHILE FORMATTING (JAVASCRIPT ERROR) to IE : Loop while formatting Word pasted data
  • Version set to FCKeditor 2.5

Confirmed with IE. No problem with other browsers.

I've reduced the TC for it:

  1. Load the following HTML:
<p><b>SAMPLE DATA<o:p></o:p></b></p>
  1. Align the "SAMPLE DATA" paragraph to right.

The browser will loop.

It works well by removing the <b> or the MS Office <o:p> tags.

comment:2 follow-up: Changed 9 years ago by oliveira_lcs

Remember that it also happens when you write text with lots of paragraphs, containing different formats, straight on fckeditor. It´s not necessarily a pasted data from word. Thanks again, Luís

comment:3 in reply to: ↑ 2 Changed 9 years ago by fredck

Replying to oliveira_lcs:

Remember that it also happens when you write text with lots of paragraphs, containing different formats, straight on fckeditor. It´s not necessarily a pasted data from word.

For that case Luis, we need the precise steps to reproduce it. We can only work on facts, not theories.

Thanks for the update.

comment:4 Changed 9 years ago by oliveira_lcs

You´re right. That happened to me on 2.5. I´ve tried to reproduce it on the actual demo page without success, so maybe it´s fixed for 2.5.1. Thank you and I hope you find a solution for the word pasted data soon.

comment:5 Changed 9 years ago by hespanhol

I found that it get in a loop at "while ( ( block = iterator.GetNextParagraph() ) )" in fckjustifycommands.js.

iterator.GetNextParagraph() keeps returning <B></B> while variable currentnode in function GetNextParagraph() have <B><?xml:namespace prefix = o /><o:p></o:p></B>

I guess it is a matter of deleting the empty tag <B></B> at the end of the function, I just dont know how to do it.

comment:6 Changed 9 years ago by martinkou

  • Owner set to martinkou
  • Status changed from new to assigned

Changed 9 years ago by martinkou

Proposed patch for fixing #1707.

comment:7 Changed 9 years ago by martinkou

  • Keywords Review? added; Confirmed IE removed

Changed 9 years ago by martinkou

Simplified patch for fixing #1707.

comment:8 Changed 9 years ago by fredck

  • Keywords Review+ added; Review? removed

Please include the changelog entry when committing.

comment:9 Changed 9 years ago by martinkou

  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed with [1409].

Click here for more info about our SVN system.

comment:10 Changed 8 years ago by oliveira_lcs

  • Resolution fixed deleted
  • Status changed from closed to reopened

I just tested with the changed file and it still freezes while formatting. Guess it needs to be reviwed. Thank you once again, Luís

comment:11 Changed 8 years ago by martinkou

Hi Luís,

Did you apply the patch to our released source package or to the SVN source tree? I'm asking this because applying the patch to the release source package has no effect - the source code in the downloadable package is there for viewing purpose only, it is not loaded by the browser. The patch is only effective if you apply it to the SVN source tree.

comment:12 Changed 8 years ago by fredck

You may also try our nightly build.

comment:13 Changed 8 years ago by fredck

  • Keywords IE added
  • Resolution set to fixed
  • Status changed from reopened to closed

I've tested it with both the reported TC as well as with the reduced TC described in comment:1. It works for me on both cases.

Feel free to reopen it if it is still a problem. In that case, please provide the precise instructions to reproduce it.

comment:14 Changed 8 years ago by oliveira_lcs

It did work for the nightly build. Thank you!!!

comment:15 Changed 2 years ago by fredck

  • Component changed from General to Plugin : Paste from Word
Note: See TracTickets for help on using tickets.
© 2003 – 2016 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy