Ticket #1853 (closed Bug: fixed)

Opened 7 years ago

Last modified 6 years ago

ShiftEnterMode don't work

Reported by: datalink Owned by: martinkou
Priority: Normal Milestone: FCKeditor 2.6
Component: UI : Enter Key Version: FCKeditor 2.5.1
Keywords: Confirmed Review+ Cc:

Description

With

FCKConfig.EnterMode = 'br' ;
FCKConfig.ShiftEnterMode = 'p' ; (or same on 'div')

Shift + Enter make <br>

Attachments

1853.patch (1.5 KB) - added by martinkou 6 years ago.
1853_2.patch (2.8 KB) - added by martinkou 6 years ago.

Change History

comment:1 Changed 7 years ago by w.olchawa

  • Keywords Confirmed added

Confirmed with IE, IE7 and FF2

comment:2 Changed 7 years ago by alfonsoml

  • Milestone set to FCKeditor 2.6

Currently it's throwing an error:

eNextBlock has no properties
http://localhost/fckdev/editor/_source/classes/fckenterkey.js
Line 421

comment:3 Changed 7 years ago by fredck

:|

I'm not able to reproduce it. Tested with IE7 and FF2, with both the SVN and 2.5.1 versions, using sample01.html with the setting changed manually in the fckconfig.js file.

Is it just me? Are there are precise steps to make this error happen?

comment:4 Changed 7 years ago by martinkou

Works perfectly for me as well.

comment:5 Changed 7 years ago by martinkou

  • Status changed from new to closed
  • Resolution set to worksforme

I've done some more tests today and I wasn't able to reproduce the issue.

comment:6 Changed 7 years ago by fredck

  • Status changed from closed to reopened
  • Resolution worksforme deleted

I'm able to reproduce it with FF2 in the nightly build with sample12.

comment:7 Changed 6 years ago by martinkou

  • Owner set to martinkou
  • Status changed from reopened to new

Changed 6 years ago by martinkou

comment:8 Changed 6 years ago by martinkou

  • Keywords Review? added

comment:9 Changed 6 years ago by alfonsoml

#1839 has been marked as dup

comment:10 Changed 6 years ago by martinkou

  • Keywords Review? removed

Retracted the review request as a better approach was discovered during a conversion with Fred today.

Changed 6 years ago by martinkou

comment:11 Changed 6 years ago by martinkou

  • Keywords Review? added

comment:12 Changed 6 years ago by fredck

  • Keywords Review+ added; Review? removed

comment:13 Changed 6 years ago by martinkou

  • Status changed from new to closed
  • Resolution set to fixed

Fixed with [1729].

Click here for more info about our SVN system.

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy