Opened 9 years ago

Closed 8 years ago

#1891 closed Bug (fixed)

fck_tablecell.html id >< name conflicts

Reported by: estan Owned by: alfonsoml
Priority: Low Milestone: FCKeditor 2.6.4
Component: UI : Dialogs Version: FCKeditor 2.5.1
Keywords: Review+ Cc:

Description

Low priority.

I noticed that a lot of input controls are not consistent with the ID and the Name. Some examples.

<select id="selWordWrap" name="selAlignment"> <select id="selHAlign" name="selAlignment"> <select id="selVAlign" name="selAlignment"> <input id="txtBackColor" type="text" size="8" name="txtCellSpacing"> <input id="txtBorderColor" type="text" size="8" name="txtCellPadding" />

As you can see here, the ID is the correct one, the name is incorrect.

Attachments (1)

1891.patch (11.3 KB) - added by alfonsoml 8 years ago.
Proposed patch

Download all attachments as: .zip

Change History (4)

Changed 8 years ago by alfonsoml

Proposed patch

comment:1 Changed 8 years ago by alfonsoml

  • Keywords Review? added
  • Owner set to alfonsoml
  • Status changed from new to assigned

The name attribute isn't really used in the dialogs (except maybe for the quick upload, so I didn't touch those, and in the link dialog for the chkFeature checkboxes)

The proposed patch removes the rest of names.

comment:2 Changed 8 years ago by martinkou

  • Keywords Review+ added; Review? removed

comment:3 Changed 8 years ago by alfonsoml

  • Milestone set to FCKeditor 2.6.4
  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed with [2374]

Note: See TracTickets for help on using tickets.
© 2003 – 2016 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy