Ticket #1917 (closed Bug: fixed)

Opened 7 years ago

Last modified 6 years ago

mergedown error / three cell

Reported by: aceseol Owned by: martinkou
Priority: Normal Milestone: FCKeditor 2.6.3
Component: General Version: SVN (FCKeditor) - Retired
Keywords: Confirmed IE HasPatch Review+ Cc:

Description

two cell mergedown ok! three cell mergedown table broken.

Attachments

fcktablehandler.js.patch (1.2 KB) - added by karena 6 years ago.
1917.patch (1.6 KB) - added by martinkou 6 years ago.

Change History

comment:1 Changed 7 years ago by w.olchawa

  • Keywords Pending added

Hi!

Could you please provide more detailed information about the bug? Also, could you please let us know what kind of browser and what version of FCKeditor are you using.

Thanks.

comment:2 Changed 7 years ago by martinkou

  • Keywords Confirmed IE added; Pending removed

Confirmed.

To reproduce the bug, open sample01.html in IE.

  1. Make a 2x3 table which is the default.
  2. Right click on a cell in the top, choose cells, merge down.
  3. Right click on the merged cell, choose again cells, merge down.
  4. The table becomes broken.

Merging in Firefox works.

comment:3 Changed 7 years ago by fredck

  • Milestone set to FCKeditor 2.7

comment:4 Changed 7 years ago by martinkou

#1941 marked as a dup of this ticket.

comment:5 Changed 7 years ago by martinkou

#2055 marked as a dup of this ticket.

comment:6 Changed 6 years ago by julia82

I'm interested in.

Changed 6 years ago by karena

comment:7 Changed 6 years ago by martinkou

  • Keywords HasPatch added
  • Version set to SVN
  • Milestone set to FCKeditor 2.6.3

comment:8 Changed 6 years ago by martinkou

  • Owner set to martinkou
  • Status changed from new to assigned

comment:9 Changed 6 years ago by martinkou

  • Keywords Review? added

Lines 733 and 734 from Karena's patch isn't really needed because we're counting the rowSpan from the tableMap data structure, so we don't really have to add up the rowSpan of the current cell if we've already stored the sum in another variable.

Karena's patch has worked around an IE bug here though, which is the essential component of the fix. Our current code does not work in IE because we're depending on IE reporting the correct rowSpan for the td elements - unfortunately when a td is not attached to a tr IE would always report its rowSpan to be 1. So Karena's way of storing the sum in a variable works around the problem.

Proposing a new patch with lines 733 and 734 from Karena's patch removed.

Changed 6 years ago by martinkou

comment:10 Changed 6 years ago by fredck

  • Keywords Review+ added; Review? removed

comment:11 Changed 6 years ago by martinkou

  • Status changed from assigned to closed
  • Resolution set to fixed

Fixed with [2158].

Click here for more info about our SVN system.

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy