Ticket #2009 (closed Bug: fixed)

Opened 7 years ago

Last modified 7 years ago

Disappearing Style Tags

Reported by: goyney Owned by: fredck
Priority: High Milestone: FCKeditor 2.6
Component: Core : Styles Version: FCKeditor 2.6 Beta
Keywords: Confirmed Review+ Cc:

Description

To recreate this yourself, go look at the current FCKeditor Demo (the nightly build does it also.)

If you have text in the RTE with an applied style, for my example we'll use bold, and you try to apply that same style above that previous style in the document, when you close the tag, it removes that same style from the rest of the document below where you closed the tag.

Example: Here is your bold text. It is typically much thicker than normal text.

If you were to move that text down and try to write a line above that line and you wanted to use some bold text, there are two ways you could do it:

First, you could write the whole line out and once the line was written, highlight the part you want bold and apply it. This works fine.

The second was is to, while typing it, stop at the word you want bold, either press the B icon in the toolbar or press CTRL+B to turn bold on, and then continue typing. When doing this, when you turn bold off by either pressing the B icon in the toolbar or using CTRL+B, it removes all style from the rest of the document that matches that style.

This is a very serious usability bug and hampers productivity for our environment. Thank you for your quick investigation and fix to this problem.

Attachments

2009.patch (1.4 KB) - added by fredck 7 years ago.

Change History

comment:1 Changed 7 years ago by wwalc

  • Keywords Confirmed added; disappear disappearing style tags removed

Changed 7 years ago by fredck

comment:2 Changed 7 years ago by fredck

  • Keywords Review? added
  • Owner set to fredck
  • Status changed from new to assigned

The code for the floating dialogs mistakenly removed a return clause from the fckstyle.js file (from line 279), which caused problems with collapsed styles removal, specially when the cursor was placed in the boundaries of the styles text.

The proposed patch reverts that return back, fixing the reported problem.

comment:3 Changed 7 years ago by martinkou

  • Keywords Review+ added; Review? removed

comment:4 Changed 7 years ago by fredck

  • Status changed from assigned to closed
  • Resolution set to fixed

Fixed with [1716]. Click here for more info about our SVN system.

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy