Ticket #2043 (closed Task: fixed)

Opened 6 years ago

Last modified 6 years ago

The FCKDebug code should not be included in the compressed files

Reported by: fredck Owned by: fredck
Priority: Normal Milestone: FCKeditor 2.6.2
Component: General Version:
Keywords: Confirmed Review+ Cc:

Description

We don't need anything from FCKDebug when normally using the editor. We should be able so to avoid including its code inside the compressed files to save some bytes from it. The solution would be loading fckdebug.js by request, only if debugging is enabled.

Our code may have some debugging calls laying around, so the compressed files should still contain the debugging functions, but those should be empty. We could use @Packager.Remove.Start and @Packager.Remove.End to easily achieve that.

Attachments

2043.patch (2.1 KB) - added by martinkou 6 years ago.
2043_2.patch (5.9 KB) - added by fredck 6 years ago.

Change History

Changed 6 years ago by martinkou

comment:1 Changed 6 years ago by martinkou

  • Status changed from new to assigned
  • Keywords Review? added
  • Owner set to martinkou

comment:2 Changed 6 years ago by fredck

  • Keywords Review- added; Review? removed
  • Owner changed from martinkou to fredck
  • Status changed from assigned to new

I had a different idea actually. I still wanted to make it possible to debug with the distributed code, even when running the compressed scripts. The proposed patch instead completely remove the debug code from the distribution, and also don't include it at all in the compressed files, which may case runtime bugs if any FCKDebug call remained in the code.

All this is quite difficult to explain in words, so I'll just attach a new patch for it.

Changed 6 years ago by fredck

comment:3 Changed 6 years ago by fredck

  • Status changed from new to assigned
  • Keywords Review? added; Review- removed

I've figured out that the Packager.Remove.Start idea was not good. The proposed patch adds a new empty file instead.

I've also taken the opportunity to rewrite the FCKDebug object definition in fckdebug.js. No code changes, just the declaration format.

comment:4 Changed 6 years ago by martinkou

  • Keywords Review+ added; Review? removed

comment:5 Changed 6 years ago by fredck

  • Status changed from assigned to closed
  • Resolution set to fixed

Fixed with [2069]. Click here for more info about our SVN system.

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy