Opened 18 years ago
Closed 17 years ago
#2142 closed New Feature (fixed)
HTML samples should use php extension in action paramter inside a form
| Reported by: | Wojciech Olchawa | Owned by: | Wojciech Olchawa | 
|---|---|---|---|
| Priority: | Normal | Milestone: | FCKeditor 2.6.1 | 
| Component: | General | Version: | SVN (FCKeditor) - Retired | 
| Keywords: | Confirmed Review+ | Cc: | 
Description
My suggestion is to replace sampleposteddata.asp with sampleposteddata.php in action parameter inside the form. I think that the usage of asp extension is less useful for the users. I don't know what is the most common used server side however I think that PHP is more popular than ASP (more of the users use Appache rather than IIS for example). Of course a user could always use the php examples however I don't see why php extension couldn't be used in html samples as well.
Attachments (2)
Change History (14)
comment:1 Changed 18 years ago by
| Keywords: | Confirmed added; Discussion removed | 
|---|---|
| Milestone: | → FCKeditor 2.6.1 | 
comment:2 Changed 18 years ago by
| Owner: | set to Wojciech Olchawa | 
|---|
comment:3 Changed 18 years ago by
I've attached a patch proposal. The patch should throw an error when trying to modify sampleposteddata.asp from _samples/html catalog. (because of attempt to delete it). However it shouldn't be a problem when committing the patch.
Changed 18 years ago by
| Attachment: | 2142.patch added | 
|---|
comment:4 Changed 18 years ago by
| Keywords: | Review? added | 
|---|
comment:5 Changed 18 years ago by
| Keywords: | Review+ added; Review? removed | 
|---|
Please, update the what's new file remarking that it's an important change from previous versions.
comment:7 Changed 18 years ago by
| Resolution: | fixed | 
|---|---|
| Status: | closed → reopened | 
Now I think that instead of copying the sampleposteddata.php it would be better to change the action so it points to ../php/sampleposteddata.php
That way there's only one copy of that file and it's absolutely clear for anyone what to do if they are working with other languages.
comment:9 Changed 18 years ago by
| Keywords: | Review+ removed | 
|---|
comment:10 Changed 18 years ago by
| Keywords: | Review? added | 
|---|
I don't see any reason for keeping sampleposteddata.html as well. I have applied changes to the patch.
comment:11 Changed 18 years ago by
| Keywords: | Review+ added; Review? removed | 
|---|


It makes a lot of sense. PHP is definitely the most used language, related to the editor (we have done a research about it previously).