Ticket #2168 (closed Bug: fixed)
Comments shouldn't create new blocks
| Reported by: | alfonsoml | Owned by: | alfonsoml |
|---|---|---|---|
| Priority: | Normal | Milestone: | FCKeditor 2.6.1 |
| Component: | Core : Output Data | Version: | FCKeditor 2.5 |
| Keywords: | Review+ | Cc: |
Description
When the body is fixed to make sure that everything is properly nested, the comment nodes should be treated specially so they don't generate a new block.
given this input:
This is <!-- some comment --> some <strong>sample text</strong>. You are using <a href="http://www.fckeditor.net/">FCKeditor</a>.
with enter mode set to P, if you switch to design and back to source the output is
<p>This is</p> <!-- some comment --> <p>some <strong>sample text</strong>. You are using <a href="http://www.fckeditor.net/">FCKeditor</a>.</p>
the paragraph has been broken
it should have been left as
<p>This is <!-- some comment --> some <strong>sample text</strong>. You are using <a href="http://www.fckeditor.net/">FCKeditor</a>.</p>
Attachments
Change History
Changed 5 years ago by alfonsoml
- Attachment 2168.patch added
comment:2 Changed 5 years ago by fredck
- Keywords Review- added; Review? removed
The fix is almost ok... it's missing a "break" for "case 3", otherwise it will fell down into the introduced "case 8" code.
comment:3 Changed 5 years ago by alfonsoml
- Keywords Review? added; Review- removed
I've included both break statements.
Note: See
TracTickets for help on using
tickets.

Proposed SVN patch