Opened 18 years ago
Closed 18 years ago
#2185 closed Bug (fixed)
FCKPackager incorrectly adds semicolons after functions passed as an argument to another function.
| Reported by: | Martin Kou | Owned by: | |
|---|---|---|---|
| Priority: | Normal | Milestone: | FCKeditor 2.6.1 |
| Component: | Project : CKPackager | Version: | SVN (FCKeditor) - Retired |
| Keywords: | Confirmed | Cc: |
Description (last modified by )
Write the following JavaScript code and let FCKPackager compress it:
void(
function(b)
{}
);
FCKPackager would give you something like this:
void(function(b){};);
Notice the semicolon after the anonymous function, it is incorrect.
This bug is causing the current FCKeditor code in the SVN unusable after running build_release.bat, because of the following code in fckdocumentprocessor.js:
if ( FCKBrowserInfo.IsSafari )
{
FCKDocumentProcessor.AppendNew().ProcessDocument = function( doc )
{
var spans = doc.getElementsByClassName ?
doc.getElementsByClassName( 'Apple-style-span' ) :
Array.prototype.filter.call(
doc.getElementsByTagName( 'span' ),
function( item ){ return item.className == 'Apple-style-span' ; }
) ;
for ( var i = spans.length - 1 ; i >= 0 ; i-- )
FCKDomTools.RemoveNode( spans[i], true ) ;
}
}
Change History (4)
comment:1 Changed 18 years ago by
| Component: | General → Project : FCKpackager |
|---|
comment:2 Changed 18 years ago by
comment:3 Changed 18 years ago by
| Description: | modified (diff) |
|---|
comment:4 Changed 18 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |

A short term fix can be committed to fckdocumentprocessor.js instead, making the closing bracket of Array.prototype.filter.call() end up in the same line as the last argument. However, a fix to FCKpackager itself would be the best if possible.