Opened 17 years ago
Closed 13 years ago
#2203 closed Bug (duplicate)
Multiple span problem
| Reported by: | James | Owned by: | Frederico Caldeira Knabben |
|---|---|---|---|
| Priority: | Normal | Milestone: | |
| Component: | Core : Styles | Version: | FCKeditor 2.5 Beta |
| Keywords: | HasPatch IBM | Cc: | monahant@… |
Description
span span span span span multiple span multiple span
I select a word, apply a font face, and a font size. View the code that just added two spans, not one as I would expect. If I make any more changes to the word it will just keep on adding spans.
Attachments (4)
Change History (16)
comment:1 Changed 17 years ago by
| Component: | General → Core : Styles |
|---|---|
| Keywords: | Confirmed added |
| Priority: | High → Normal |
| Version: | → FCKeditor 2.5 Beta |
comment:2 Changed 17 years ago by
| Owner: | set to Frederico Caldeira Knabben |
|---|---|
| Version: | FCKeditor 2.5 Beta → FCKeditor 2.6.3 |
comment:3 Changed 17 years ago by
bug fouhd..content being replaced if applying a style to a larger selection. Will fix and reattach next week.
comment:4 Changed 17 years ago by
| Version: | FCKeditor 2.6.3 → FCKeditor 2.5 Beta |
|---|
comment:5 Changed 17 years ago by
BTW, this patch tries to merge nodes after applying the styles, but I think that the ideal solution would be to adjust the range so it gets the correct node and then apply the styles to that node, instead of creating a node inside of it and then try to merge it back with its parent.
comment:6 Changed 17 years ago by
Tried the patch out. Very promising. I noticed that it would convert a strong tag to a span tag when applying the style. But definitely headed in the right direction more like the type of content that you'd expect an editor to output.
comment:7 Changed 17 years ago by
For some reason, the issue did not correctly update the orignal file I uploaded. Try the new one http://dev.fckeditor.net/attachment/ticket/2203/fckstyle.2.js
and the strong tag problem you noted should be fixed.
comment:8 Changed 17 years ago by
Download from that link. It said it was posted 16hours ago and still has the problem with strong tags.
Changed 17 years ago by
| Attachment: | fckstyle.3.js added |
|---|
update to fckstyle.js - three functions added (_MergeChildren, _MergeFirstChild, _MergeLastChild)
comment:9 Changed 17 years ago by
Took the time to checkout the svn repository and create a proper patch..sorry for the mess of previous comments and attached files.
comment:10 Changed 16 years ago by
| Keywords: | HasPatch added |
|---|
comment:11 Changed 13 years ago by
| Cc: | monahant@… added |
|---|---|
| Keywords: | IBM added |
comment:12 Changed 13 years ago by
| Resolution: | → duplicate |
|---|---|
| Status: | confirmed → closed |
We have implemented the missing merge style section. Tested in ie, firefox, chrome and safari.
Please consider for trunk.