Unnecessary link piping

[Joe Beaudoin Jr.]

When defining links, every single link is piped, regardless of whether it is necessary or not.

For instance

[[William Adama]]

turns into

[[William Adama|William Adama]]

It is a mild irritation for those who like clean code (wiki or otherwise), since piping is unnecessary in the above case.

[wwalc]

I can't find any issues with it. Go ahead committing it.

[arczi]

It didn't work with link dialog. Repaired in 2223_2.patch

[arczi]

Fixed with 2394

[wwalc]

Fixed with [2394].

[wwalc]

Ooops, it still doesn't work with links that contain underscore:

[[Foo_Bar]]

is changed into:

[[Foo Bar|Foo_Bar]]

[wwalc]

Unfortunately I have found another example that still doesn't work:

[[Help:Link#Subpage feature]]

is changed into

[[Help:Link#Subpage feature#Subpage feature|Help:Link#Subpage feature]]

[wwalc]

It looks like [2394] completely broken parsing tags inside of [[ ]] (!).

When using revision 2388, Images are displayed properly when switching to wikitext and back:

[[Image:Test.gif]]

when using current revision, they're changed into links.

This definitely has something to do with adding RTENOTITLE straight after [[ which changes everything into a link.

[wwalc]

Looks very good. I didn't check it deeply, but when checking random articles from MediaWiki I managed to find just two more issues:

[[Official position]]s

is changed into:

[[Official position|RTENOTITLEs]]

Links to categories now are broken:

[[Category:Help]]

changes into:

[[Category:Help|RTENOTITLE]]

I haven't checked it, but it seems that this code either removes the following feature, or moves it into other place, could you explain it? It looks like it:

• removes fix for #2075 in FCKeditorParser.body.php
• removes fix for #2483 in FCKeditorSkin.body.php (RTECOLON)

[arczi]

I need to change RTECOLON to ':' before creating A tag so there is no point in doing it one more time.

makeSelfLinkObj is changed so line

$text = preg_replace("/<strong class=\"selflink\">(.*?)<\/strong>/", 
"<a href=\"".$this->mTitle->mDbkeyform."\" class=\"selflink\">$1</a>", $text);

is now useless, of course selflinks still work.

I attached a list of expressions.

[wwalc]

Review-, FCKeditor should at least leave those links functional (below are examples of known and unkown links):

[[Main_Page#Limitations_and_workarounds]]
[[Main_Page#Limitations_and_workarounds|Limitations_and_workarounds]]
[[Main_Page#Limitations_and_workarounds|Limitations and workarounds]]
[[Main_Page#Limitations_and_workarounds|Main_Page#Limitations_and_workarounds]]
[[Main_Page#Limitations_and_workarounds|Main_Page#Limitations and workarounds]]
[[Main_Page#Limitations_and_workarounds|Limitations]]

[[Main_Pag#Limitations_and_workarounds]]
[[Main_Pag#Limitations_and_workarounds|Limitations_and_workarounds]]
[[Main_Pag#Limitations_and_workarounds|Limitations and workarounds]]
[[Main_Pag#Limitations_and_workarounds|Main_Pag#Limitations_and_workarounds]]
[[Main_Pag#Limitations_and_workarounds|Main_Pag#Limitations and workarounds]]
[[Main_Pag#Limitations_and_workarounds|Limitations]]

Another issue I found is that in makeSelfLinkObj() $args is not initialized.

[wwalc]

Ok, let's give it a try.

Please remove this code from makeBrokenLinkObj():

//[[Main page]] -> [[Main_page]]
$u = str_replace($nt->getText(), $nt->getDBkey(), $u);

(let's keep the more user friendly names for links).

[wwalc]

Ooops unfortunately I have to change my opinion.

[[[[wikipedia:]]]]

is changed into

[[[[:wikipedia:|http://en.wikipedia.org/wiki/]]]]

all other things seems to work fine.

Example taken from ​http://meta.wikimedia.org/wiki/Help:Interwiki_linking .

[wwalc]

Review+, I found at least one minor bug which has left, but it I believe this patch can be comitted already and we can fix those minor bugs in new tickets. This way it will be easier to track if we break something else while fixing those less important bugs.

[arczi]

Fixed with [2466]