Malfunction in FCKSelection object

[jenka1980]

FCKSelection have 2 methods called: HasAncestorNode and MoveToAncestorNode. Both of theme have input parameter called nodeTagName of type string and as written in comments of this function the passed string should be written in upper case.

But in the code when check is done actual tag name never converted to upper case.

if ( oContainer.tagName == nodeTagName ) return true ;

So if your edited HTML has tags written in lower case (like custom tags) this functions won't find the ancestor tag.

Hope you'll fix this small thing in next revision.

tank's

[martinkou]

Hmm... the patch has a number of problems:

1. toLocalUpperCase() is not defined, which gives out JavaScript errors.
2. Even converting the toLocalUpperCase() to toUpperCase(), the patch is still wrong because it still can't check against DOM nodes with lowercase tag names.

We actually have a shorthand string function defined in FCKeditor's code for this kind of case insensitive string matching - String::IEquals(). You can find it in $FCKeditor/editor/_source/fckjscoreextensions.js, it's a very useful function. :)

[alfonsoml]

BTW, I think that sometimes Safari does return node names with a different case than the rest of the browsers. Am I right?

Do you think that this can fix any other problem?

[martinkou]

Hmm... no? Safari gives out upper case nodeNames for HTML nodes, just the same as any other browser at the moment.

[martinkou]

Fixed with [2046].

Click here for more info about our SVN system.

[fredck]

I've reverted [2046] with [2063]. The context menu was broken in IE.

[martinkou]

Ok, tagName is not always defined for all DOM nodes, particularly for the #document node.

Changing to checking for nodeName instead.

[martinkou]

Fixed with [2072].

Click here for more info about our SVN system.