Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#236 closed Bug (wontfix)

Support for shared toolbar in a different frame

Reported by: MartinH Owned by: martinkou
Priority: Normal Milestone: FCKeditor 2.5 Beta
Component: General Version: FCKeditor 2.3.2
Keywords: Cc:

Description

Hello,

There are some issues when we use shared toolbar in a separate frame, could you please have a look at that and see if you can fix or add support for those?

We use toolbar location: "Out:parent.frames['edittoolbar'](FCKToolbar)" and <div id="FCKToolbar"></div> within the target frame

Everything works fine, but:

In Firefox, the popup dialog (like color selection) does not overlap the frame border and it is useless for that reason. In IE works fine. We have made the quick fix to support displaying the dialogs within different frame and I think it would be wise to include that in your code, here are the changes:

In function: var FCKPanel = function( parentWindow ) at classes/FCKPanel.js change

this._Window.document.body.appendChild( oIFrame );

to

if ( (FCKConfig.PopupWindowFrameName != null) && (FCKConfig.PopupWindowFrameName != ) && (this._Window.parent != null) && (this._Window.parent.frames[FCKConfig.PopupWindowFrameName] != null) )

this._Window.parent.frames[FCKConfig.PopupWindowFrameName].document.body.appendChild(oIFrame);

else

this._Window.document.body.appendChild( oIFrame );

And add the configuration setting FCKConfig.PopupWindowFrameName as a string which determines target frame name for the popup windows.

The second issue is that in IE displaying the very same popup dialogs it seems like the editor area is loosing the focus. This seems to occur ramdomly, but mostly the focus is lost and the chosen format is not applied. This works fine in FF, focus is kept over there.

I would be really glad if you could have a look at the whole "different frame toolbar" problematics, I am sure it would actually help many users using your product.

Thank you for your time, your product is great.

Best regards Martin Hejtmanek

  • Kentico Software
  • Kvetna 4, 603 00 Brno, Czech Republic
  • Phone: +420 544 527 146
  • U.S. Toll Free: 1-888-225-2767
  • E-mail: martinh@…
  • WWW: http://www.kentico.com
  • we help you deliver better web sites

Change History (5)

comment:1 Changed 8 years ago by fredck

  • Milestone set to FCKeditor 2.5

comment:2 Changed 8 years ago by martinkou

  • Owner set to martinkou
  • Status changed from new to assigned

comment:3 Changed 8 years ago by martinkou

  • Resolution set to wontfix
  • Status changed from assigned to closed

Technically, it is incorrect that the color selection menu could overlap the frame border, as it is supposed to be part of the same frame with the toolbar. The overlapping you see in IE is actually an IE bug.

I don't think allowing the color selection (or similar) dialog to be displayed in a third frame would work well for this situation. The color selection dialog, when activated, is supposed to be displayed right next to the color selection button in the toolbar. It would feel very strange to a user if it is displayed in a frame separate from the editing area's and the toolbar's. And even if you've managed to make it feel natural in some way, there's the focusing issue you've mentioned.

comment:4 Changed 8 years ago by fredck

I would strongly recommend an IFRAME design here, instead of FRAMESET. You can have the same good results with the former, removing all limitations imposed by the later.

comment:5 Changed 8 years ago by alfonsoml

#1526 has been marked as dup

Note: See TracTickets for help on using tickets.
© 2003 – 2015 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy