Opened 8 years ago

Closed 7 years ago

#2653 closed Bug (fixed)

Changing table properties cannot be undone (undoes the previous action instead)

Reported by: thiloplanz Owned by: alfonsoml
Priority: Normal Milestone: FCKeditor 2.6.4
Component: UI : Dialogs Version: FCKeditor 2.3.3
Keywords: Confirmed Review+ Cc:

Description

changing table properties does not insert an undo step. The result of this is that the change in properties cannot be undone. The previous action is undone instead.

The attached patch (fck_table.html) will always insert an undo step, which currently only happens when the table is initially created. This seems to fix the problem (the jury is still out on potential negative implications, but it looks safe).

Attachments (1)

fck_table.html.patch (704 bytes) - added by thiloplanz 8 years ago.
patch for fck_table.html (rev 2674)

Download all attachments as: .zip

Change History (7)

Changed 8 years ago by thiloplanz

patch for fck_table.html (rev 2674)

comment:1 Changed 8 years ago by thiloplanz

  • Component changed from General to UI : Dialogs

comment:2 Changed 8 years ago by arczi

  • Keywords Confirmed HasPatch added; table undo removed
  • Version changed from FCKeditor 2.6.3 to FCKeditor 2.3.3

comment:3 Changed 7 years ago by thiloplanz

Changing table cell properties has the same problem, see #2733

comment:4 Changed 7 years ago by alfonsoml

  • Keywords Review? added; HasPatch removed
  • Owner set to alfonsoml
  • Status changed from new to assigned

As both tickets are so similar I'm providing a single patch that includes both changes. It's just the fix proposed by thiloplanz for each one with a what's new entry.

comment:5 Changed 7 years ago by martinkou

  • Keywords Review+ added; Review? removed

comment:6 Changed 7 years ago by alfonsoml

  • Milestone set to FCKeditor 2.6.4
  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed with [2861]. Thanks for the report and patch.

Note: See TracTickets for help on using tickets.
© 2003 – 2016 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy