Styles cannot be applied when a whole paragraph is selected

[Martin Kou]

To reproduce:

1. Open replacebyclass.html in Firefox 3.
2. Double click on the empty area to the right of the first paragraph to select the whole paragraph.
3. Try to apply any style, e.g. press the bold button.
4. It doesn't work.

[Garry Yao]

It works for me with FF3.0.5

[Martin Kou]

It works sometimes, but other times it doesn't work. I've tested under Firefox 3.0.5 with OSX Leopard and Windows XP.

[Martin Kou]

Ok, I think I've found a way to reliably reproduce this.

The trick to reproduce the bug is to triple click on the right side of the paragraph. Double click doesn't seem to trigger the bug.

[Martin Kou]

The problem was found to be caused by line 226 in the style plugin. Whenever the user triple clicks to the right of a paragraph, the selection range becomes like this:

<p>^This is some <b>sample text</b>. You ...^</p>

Line 226 in the style plugin expands the selection range to include the outermost element. Thus, after line 226, the range becomes like this:

^<p>This is some <b>sample text</b>. You ...</p>^

The logic after line 226 assumes everything in the range is inline stuff, but turns out we've got a block in the range. So the range is ignored.

My patch adds a mode to CKEDITOR.dom.range::enlarge() called CKEDITOR.ENLARGE_INLINE_ELEMENTS. It does the same thing as CKEDITOR.ENLARGE_ELEMENT, but stops when a non-inline element is met.

[Martin Kou]

Retracted review request, the patch seems to cause other problems with inline styles.

[Martin Kou]

Ok, the bug with the previous patch should be fixed.

[Frederico Caldeira Knabben]

The problem here is not really the "enlarge" call, which is correct and has the expected behaviour. The real problem is that the <p> is set as the first node to be processed *and* the last node, which stops processing. So, nothing happens.

There is a simple solution for it. I'll come with a new patch.

[Frederico Caldeira Knabben]

Fixed with [3209].