Opened 16 years ago
Closed 16 years ago
#2856 closed Bug (fixed)
Inches and Centimetres
Reported by: | Ajos1 | Owned by: | Artur Formella |
---|---|---|---|
Priority: | Normal | Milestone: | FCKeditor 2.6.5 |
Component: | General | Version: | FCKeditor 2.4 |
Keywords: | Confirmed Review+ | Cc: |
Description
We still have people that work in Inches and NOT Centimetres. (Do not tell me off... I am trying to change them).
In "fckeditor/editor/dialog/fck_paste.html" (CleanWord) you have:
Remove margin styles. html = html.replace( /\s*MARGIN: 0cm 0cm 0pt\s*;/gi, ) ; html = html.replace( /\s*MARGIN: 0cm 0cm 0pt\s*"/gi, "\"" ) ;
html = html.replace( /\s*TEXT-INDENT: 0cm\s*;/gi, ) ; html = html.replace( /\s*TEXT-INDENT: 0cm\s*"/gi, "\"" ) ;
You might want to change to:
Remove margin styles. html = html.replace( /\s*MARGIN: 0cm 0cm 0pt\s*;/gi, ) ; html = html.replace( /\s*MARGIN: 0cm 0cm 0pt\s*"/gi, "\"" ) ;
html = html.replace( /\s*MARGIN: 0in 0in 0pt\s*;/gi, ) ; html = html.replace( /\s*MARGIN: 0in 0in 0pt\s*"/gi, "\"" ) ;
html = html.replace( /\s*TEXT-INDENT: 0cm\s*;/gi, ) ; html = html.replace( /\s*TEXT-INDENT: 0cm\s*"/gi, "\"" ) ;
html = html.replace( /\s*TEXT-INDENT: 0in\s*;/gi, ) ; html = html.replace( /\s*TEXT-INDENT: 0in\s*"/gi, "\"" ) ;
Attachments (2)
Change History (11)
comment:1 Changed 16 years ago by
comment:2 Changed 16 years ago by
Milestone: | FCKeditor 2.6.5 |
---|
comment:3 Changed 16 years ago by
Keywords: | Confirmed added |
---|---|
Version: | FCKeditor 2.6.4 → FCKeditor 2.4 |
Changed 16 years ago by
Attachment: | 2856.patch added |
---|
comment:4 Changed 16 years ago by
Keywords: | Review? added |
---|
comment:5 Changed 16 years ago by
Keywords: | Review- added; Review? removed |
---|
Can you use non-capturing in the regex? -> /\s*MARGIN: 0(?:cm|in) 0(?:cm|in) 0pt\s*
And the what's new entry is missing.
Changed 16 years ago by
Attachment: | 2856.2.patch added |
---|
comment:6 Changed 16 years ago by
Keywords: | Review? added; Review- removed |
---|---|
Milestone: | → FCKeditor 2.6.5 |
Owner: | set to Artur Formella |
Status: | new → assigned |
comment:7 Changed 16 years ago by
Keywords: | Review+ added; Review? removed |
---|
comment:9 Changed 16 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Okay... the code segments got messed up...
You have 4 lines of code with "0cm", it might be useful having an extra 4 lines of similar code but with "0in".