Opened 6 years ago

Closed 6 years ago

#2947 closed Bug (fixed)

Indent does not work in IE

Reported by: fredck Owned by: martinkou
Priority: Normal Milestone: CKEditor 3.0
Component: General Version: 3.0 Beta
Keywords: Confirmed IE IBM Review+ Cc:

Description

The indentation button has no effect in IE. Works well with Firefox, Safari and Opera.

Attachments (2)

2947.patch (1.5 KB) - added by martinkou 6 years ago.
2947_2.patch (1.1 KB) - added by martinkou 6 years ago.

Download all attachments as: .zip

Change History (9)

comment:1 Changed 6 years ago by martinkou

  • Owner set to martinkou
  • Status changed from new to assigned

Changed 6 years ago by martinkou

comment:2 Changed 6 years ago by martinkou

  • Keywords Review? added

comment:3 Changed 6 years ago by fredck

  • Keywords Review- added; Review? removed

The indent plugin code is correct. The code to be fixed is element::getAttribute.

Changed 6 years ago by martinkou

comment:4 Changed 6 years ago by martinkou

  • Keywords Review? added; Review- removed

comment:5 Changed 6 years ago by garry.yao

The fix to element::getAttribute overlaps part of the patch of #2862.

comment:6 Changed 6 years ago by fredck

  • Keywords Review+ added; Review? removed

Please move the lowercase fix to the element class constructor, right after the _cke_saved_href check and go ahead committing.

comment:7 Changed 6 years ago by martinkou

  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed with [3100].

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy