Ticket #2964 (closed Bug: fixed)

Opened 6 years ago

Last modified 6 years ago

plugin:image dialog loading cause JavaScript Error

Reported by: garry.yao Owned by: garry.yao
Priority: Normal Milestone: CKEditor 3.0
Component: General Version: SVN (FCKeditor) - Retired
Keywords: Confirmed Review+ Cc:

Description

Procedures

  1. Open the replace by code example page in IE;
  2. Click image button to open dialog.
  • Actual Result : Encounter JavaScript error thrown.

Attachments

2964.patch (785 bytes) - added by garry.yao 6 years ago.
2964_2.patch (797 bytes) - added by garry.yao 6 years ago.
Update with SVN
2964_3.patch (800 bytes) - added by garry.yao 6 years ago.

Change History

Changed 6 years ago by garry.yao

comment:1 Changed 6 years ago by garry.yao

  • Status changed from new to assigned
  • Keywords Review? added
  • Owner set to garry.yao

comment:2 Changed 6 years ago by martinkou

  • Status changed from assigned to closed
  • Resolution set to invalid

Hey, you forgot to update your local code copy. ;-)

That was fixed yesterday with [3096].

Changed 6 years ago by garry.yao

Update with SVN

comment:3 Changed 6 years ago by garry.yao

  • Status changed from closed to reopened
  • Resolution invalid deleted

Thanks for remind, but the fix of [3096] is incomplete though.

comment:4 Changed 6 years ago by martinkou

  • Keywords Review?- added; Review? removed

Oh, yes, you're right. Fred's fix was incomplete.

But can you please change the this._.dialog line to this.getDialog()? Properties in _ are supposed to be "private". And the image plugin isn't too closely related to the dialog plugin to be reasonably given access to a dialog object's private variables.

comment:5 Changed 6 years ago by martinkou

  • Keywords Review- added; Review?- removed

Changed 6 years ago by garry.yao

comment:6 Changed 6 years ago by garry.yao

  • Keywords Review? added; Review- removed

comment:7 Changed 6 years ago by fredck

  • Keywords Review+ added; Review? removed

comment:8 Changed 6 years ago by garry.yao

  • Status changed from reopened to closed
  • Resolution set to fixed

comment:9 Changed 6 years ago by garry.yao

Fixed with [3105]

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy