Ticket #2964 (closed Bug: fixed)
plugin:image dialog loading cause JavaScript Error
| Reported by: | garry.yao | Owned by: | garry.yao |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.0 |
| Component: | General | Version: | SVN (FCKeditor) - Retired |
| Keywords: | Confirmed Review+ | Cc: |
Description
Procedures
- Open the replace by code example page in IE;
- Click image button to open dialog.
- Actual Result : Encounter JavaScript error thrown.
Attachments
Change History
comment:1 Changed 4 years ago by garry.yao
- Status changed from new to assigned
- Keywords Review? added
- Owner set to garry.yao
comment:2 Changed 4 years ago by martinkou
- Status changed from assigned to closed
- Resolution set to invalid
Hey, you forgot to update your local code copy. ;-)
That was fixed yesterday with [3096].
comment:3 Changed 4 years ago by garry.yao
- Status changed from closed to reopened
- Resolution invalid deleted
Thanks for remind, but the fix of [3096] is incomplete though.
comment:4 Changed 4 years ago by martinkou
- Keywords Review?- added; Review? removed
Oh, yes, you're right. Fred's fix was incomplete.
But can you please change the this._.dialog line to this.getDialog()? Properties in _ are supposed to be "private". And the image plugin isn't too closely related to the dialog plugin to be reasonably given access to a dialog object's private variables.
Note: See
TracTickets for help on using
tickets.
