Ticket #3 (closed Task: fixed)

Opened 7 years ago

Last modified 7 years ago

Merge fck_1.js and fck_2.js to fck.js

Reported by: FredCK Owned by: alfonsoml
Priority: Normal Milestone: FCKeditor 2.4
Component: General Version:
Keywords: Cc:

Description

In the past, we have used a different loading system that separated the code in three files. We have understood that it doesn't gave us so much in the loading performance, and the method has been changed. Now we have just one file with all the code.

To better organize the code, we must now merge the fck_1.js and fck_2.js files (and their respective browser specific implementations) to the fck.js file.

Change History

comment:1 Changed 7 years ago by alfonsoml

  • Status changed from new to assigned
  • Owner set to alfonsoml

comment:2 Changed 7 years ago by alfonsoml

I've committed the changes to my branch, I've tried to put everything under the FCK object as other new code instead of just leaving as FCK.

The basic test that I've done seem to work without problems

comment:3 Changed 7 years ago by FredCK

It seams to be everything ok with the merge. I'm just worried about the order things get executed. But actually nothing happens until the StartEditor function is called.

The only way to be sure we are loading things in the right order, is by defining a dependency map. Actually, the FCKScriptLoader is here for that, but it is still incomplete. I'm opening ticket #44 for that.

Maybe it is a good idea to move it to trunk. In this way, both of us will be testing it during other developments.

comment:4 Changed 7 years ago by alfonsoml

  • Status changed from assigned to closed
  • Resolution set to fixed

I've commited the changes to the trunk. When I did the changes I moved the fckevents.js order because that was the only file that I saw as a direct dependency that was called during the load, the rest of the code was definition of the functions so it doesn't matter if the objects are still loaded or not and I didn't want to mess too much.

comment:5 Changed 7 years ago by FredCK

  • Milestone set to FCKeditor 2.4
Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy