Ticket #3002 (closed Bug: fixed)

Opened 6 years ago

Last modified 5 years ago

Use "filters" for the htmlParser API

Reported by: fredck Owned by: fredck
Priority: Normal Milestone: CKEditor 3.0
Component: General Version:
Keywords: Confirmed Review+ Cc:

Description

Currently, we are introducing specific output manipulation directly into the domParser code. This makes that code quite hard to maintain, and less flexible, as it is not able to customize the manipulation with easy.

There should be instead a way to attach a "filter" to the parser, including all necessary rules for it.

In this the data processor can have a public filter property, which can be easily modified by a plugin or external code.

Attachments

3002.patch (61.1 KB) - added by fredck 5 years ago.

Change History

Changed 5 years ago by fredck

comment:1 Changed 5 years ago by fredck

  • Keywords Review? added
  • Status changed from new to assigned

The provided patch introduces a quite drastic change in the way we manipulate data. It now parses it not only on output, but also on input (see #3003). Also, all the data transformation logic is now modular, so plugins can easily include their own filtering rules. The fakeobject system now uses it.

comment:2 Changed 5 years ago by fredck

A good example of this code modularization is #3071.

comment:3 Changed 5 years ago by martinkou

  • Keywords Review+ added; Review? removed

comment:4 Changed 5 years ago by fredck

  • Status changed from assigned to closed
  • Resolution set to fixed

Fixed with [3172].

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy