Opened 6 years ago

Closed 2 years ago

#3032 closed Bug (fixed)

Event 'instanceReady' doesn't work in certain case

Reported by: garry.yao Owned by: garry.yao
Priority: Normal Milestone:
Component: General Version: 3.0 Beta 2
Keywords: Cc:

Description

Specifically, the instanceReady was triggered twice when edito r created in 'append' mode and the editor isn't fully interacted in because of incorrect state of 'dirty' flag.

Attachments (3)

test-editor-instanceReady.patch (2.1 KB) - added by garry.yao 6 years ago.
Functional test case.
test-editor.patch (1.6 KB) - added by garry.yao 6 years ago.
Updated Functiona Test Case
3032.patch (749 bytes) - added by garry.yao 6 years ago.

Download all attachments as: .zip

Change History (13)

Changed 6 years ago by garry.yao

Functional test case.

comment:1 Changed 6 years ago by fredck

  • Priority changed from Normal to High

comment:2 Changed 6 years ago by garry.yao

  • Owner set to garry.yao
  • Status changed from new to assigned

Changed 6 years ago by garry.yao

Updated Functiona Test Case

Changed 6 years ago by garry.yao

comment:3 Changed 6 years ago by garry.yao

  • Keywords Review? added

comment:4 Changed 6 years ago by fredck

  • Keywords Review- WorksForMe added; Review? removed

I can't understand this issue fully. The ticket points to "instanceReady" being fired twice, and the test case is checking for the dirty state.

I've changed the replacebycode sample, making the following for the first instance:

CKEDITOR.replace( 'editor1',
	{
		on :
		{
			instanceReady : function( ev )
				{
					document.title += ' (' + ev.editor.name + ')';
				}
		}
	} );

Everything works properly, and the event is always fired, once only.

Maybe this has been fixed by recent changes. Can you confirm it, giving a real example other than the test case?

comment:5 Changed 6 years ago by garry.yao

The description is misleading and out-of-date, the problem handled by this ticket is only about:
Event listener for "instanceReady" doesn't grab a correct 'dirtyFlag' value, as the TC described, Since this is a internal error, it's hard to reproduce at UI level.

comment:6 Changed 6 years ago by fredck

  • Keywords WorksForMe removed
  • Priority changed from High to Normal

comment:7 Changed 6 years ago by fredck

  • Milestone changed from CKEditor 3.0 to CKEditor 3.x

comment:8 Changed 6 years ago by alfonsoml

  • Version changed from SVN (FCKeditor) to CKEditor 3.0 Beta 2

comment:9 Changed 5 years ago by fredck

  • Milestone CKEditor 3.x deleted

Milestone CKEditor 3.x deleted

comment:10 Changed 2 years ago by Reinmar

  • Resolution set to fixed
  • Status changed from review_failed to closed

Expired. TC we currently have points to #9872.

Note: See TracTickets for help on using tickets.
© 2003 – 2015 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy