Ticket #3105 (closed Bug: invalid)

Opened 6 years ago

Last modified 18 months ago

insertHtml and insertElement should agree on the result

Reported by: garry.yao Owned by:
Priority: Normal Milestone:
Component: General Version: 3.0 Beta 2
Keywords: IE Webkit Cc:

Description (last modified by garry.yao) (diff)

Currently CKEDITOR.editor.insertHtml and CKEDITOR.editor.insertElement are having different results when the inserted element happened to be malformed or schema-violated.
This is because insertHtml is depending some native methods like pasteHtml to perform revision, from which the result may vary from browser to browser. While insertElement is all about our own logic, which perform no revision at all( The revision logic is proposing at #3100 though).

Attachments

test-insertHtml.2.patch (5.4 KB) - added by garry.yao 6 years ago.
Functional Test Case

Change History

comment:1 Changed 6 years ago by garry.yao

  • Keywords IE Webkit added
  • Description modified (diff)

The attached test case's result are different from FF to IE to Webkit.

Changed 6 years ago by garry.yao

Functional Test Case

comment:2 Changed 5 years ago by fredck

  • Milestone changed from CKEditor 3.0 to CKEditor 3.x

comment:3 Changed 5 years ago by alfonsoml

  • Version changed from SVN (FCKeditor) to CKEditor 3.0 Beta 2

comment:4 Changed 4 years ago by fredck

  • Milestone CKEditor 3.x deleted

Milestone CKEditor 3.x deleted

comment:5 Changed 18 months ago by Reinmar

  • Status changed from new to closed
  • Resolution set to invalid

Over the years meaning of these methods changed. Currently both are implemented using only our custom code, but insertHtml is more "external" (it does clean up and filtering) when insertElement is an "internal" method (I do not mean that it is private, but that it does not handle input, invalid data).

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy