Ticket #3148 (closed Task: fixed)

Opened 6 years ago

Last modified 6 years ago

Implement a simpler way for loading external plugin JavaScript files

Reported by: martinkou Owned by: fredck
Priority: High Milestone: CKEditor 3.0
Component: General Version: SVN (FCKeditor) - Retired
Keywords: Oracle Review+ Cc: Senthil

Description

External plugin files are often not named plugin.js, so that CKEDITOR.plugins.addExternal() don't work for them.

The current solution is that the web app developer using CKEditor would define a separate function called CKEDITOR_GETURL() that will scan for patterns of his files and output the correct URL.

While the approach works, it is still too complicated and error-prone for many web app developers. A simpler way is needed to enable external plugins with arbitrary file names to be loaded.

Attachments

3148.patch (2.8 KB) - added by fredck 6 years ago.
3148_2.patch (4.8 KB) - added by garry.yao 6 years ago.

Change History

Changed 6 years ago by fredck

comment:1 Changed 6 years ago by fredck

  • Keywords Review? added
  • Status changed from new to assigned

With the proposed patch, addExternal accepts a third optional parameter for the file name. If not provided, the default name is used.

Changed 6 years ago by garry.yao

comment:2 Changed 6 years ago by garry.yao

I've added test case along with the patch.

comment:3 Changed 6 years ago by martinkou

  • Keywords Review+ added; Review? removed

comment:4 Changed 6 years ago by fredck

  • Status changed from assigned to closed
  • Resolution set to fixed

Fixed with [3245].

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy