Ticket #3198 (closed Bug: fixed)

Opened 4 years ago

Last modified 4 years ago

Insertion with content deleted not working

Reported by: garry.yao Owned by: garry.yao
Priority: Normal Milestone: CKEditor 3.0
Component: General Version:
Keywords: Confirmed Review- Cc:

Description

Reproducing Procedures

  1. Open the replace by class example page;
  2. Make a selection which contains some content;
  3. Open Smiley dialog to insert a random icon;
    • Actual Result: JavaScript Error occurred.

Attachments

3198.patch​ (1.4 KB) - added by garry.yao 4 years ago.

Change History

comment:1 Changed 4 years ago by garry.yao

  • Status changed from new to assigned
  • Keywords Review? added

The patch is also fixing other plugins which has the same problem.

Changed 4 years ago by garry.yao

comment:2 Changed 4 years ago by fredck

  • Keywords Review- added; Review? removed

The patch is ok, but let's wait for #3001 to be completed because it's proposing removing all these weak points from the dialogs that got fixed here. At that point we'll be able to check if this ticket is still valid.

comment:3 Changed 4 years ago by garry.yao

  • Status changed from assigned to closed
  • Resolution set to fixed

Fixed at #3001.

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy