Image dialog problem after close

[Garry Yao]

Reproducing Procedures

1. Open the replace by class example page;
2. Click on 'Image' dialog button to open dialog;
3. Click on 'Cancel' button to close the dialog;
   • Actual Result: An JavaScript Error thrown;

[Garry Yao]

Refine the logic of clearing the preview area, which caused the error.

[Artur Formella]

The patch is OK but why it stops working in onHide?

[Garry Yao]

Actually there's some ambiguity with 'onHide' event which is actually fired after the dialog closed, the dialog system will unfortunately remove the dialog element from DOM temporarily, which cause subsequent update catch a 'element not found' error.
It's better for this case if there's a 'onBeforeHide' event which will certainly promising, but hooking it in 'onOk' and 'onCancel' conform to KISS as well.

[Artur Formella]

Oh, yes. I've found it.

onHide() in the dialog without access to the dialog is less useful and less intuitive.

End-developers might have problems with that.

I think dialog should be removed after onHide is called.

[Frederico Caldeira Knabben]

Replying to arczi:

I think dialog should be removed after onHide is called.

You are correct Artur... that's the right way for it.

[Garry Yao]

Fixed with [3300]. Click here for more info about our SVN system.