Ticket #3282 (closed Bug: fixed)

Opened 5 years ago

Last modified 5 years ago

Skin files are not being loaded with timestamp

Reported by: fredck Owned by: garry.yao
Priority: Normal Milestone: CKEditor 3.0
Component: General Version:
Keywords: Confirmed Review+ Cc:

Description

Looking at file requests in nightly build (skins) sample, it's possible to note that the skin.js file and the main CSS files don't have the timestamp ("t") parameter in the URL. We must ensure this parameter is properly sent to the server.

Attachments

3282.patch (1.1 KB) - added by garry.yao 5 years ago.
3282_2.patch (955 bytes) - added by garry.yao 5 years ago.

Change History

comment:1 Changed 5 years ago by garry.yao

  • Owner set to garry.yao
  • Status changed from new to assigned

Changed 5 years ago by garry.yao

comment:2 Changed 5 years ago by garry.yao

  • Keywords Review? added

comment:3 Changed 5 years ago by fredck

  • Keywords Review- added; Review? removed

The patch is broken. I'm not able to apply it.

Even though, the changes look by reading the patch file directly. But, I would prefer applying it for a final check.

Changed 5 years ago by garry.yao

comment:4 Changed 5 years ago by garry.yao

  • Keywords Review? added; Review- removed

Not sure why the original patch is broken.

comment:5 Changed 5 years ago by martinkou

  • Keywords Review+ added; Review? removed

comment:6 Changed 5 years ago by garry.yao

  • Status changed from assigned to closed
  • Resolution set to fixed

Fixed with [3380].

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy