Opened 7 years ago

Closed 7 years ago

#3401 closed New Feature (fixed)

V3 - Implement baseHref functionality

Reported by: arczi Owned by: garry.yao
Priority: Normal Milestone: CKEditor 3.1
Component: General Version: SVN (CKEditor) - OLD
Keywords: Confirmed Review+ Cc:

Description

We have base tag config but it works in preview only.

Attachments (4)

3401.patch (21.8 KB) - added by garry.yao 7 years ago.
3401_2.patch (2.9 KB) - added by garry.yao 7 years ago.
3401_3.patch (2.0 KB) - added by garry.yao 7 years ago.
3401_4.patch (3.0 KB) - added by garry.yao 7 years ago.

Download all attachments as: .zip

Change History (23)

comment:1 Changed 7 years ago by arczi

  • Summary changed from V3 - Implement basetag funcionality to V3 - Implement basetag functionality

comment:2 Changed 7 years ago by fredck

What do you mean with "basetag"? Is it the "baseHref" setting?

comment:3 Changed 7 years ago by arczi

Yes. I mean baseHref setting.

comment:4 Changed 7 years ago by fredck

  • Milestone changed from CKEditor 3.x to CKEditor 3.1

comment:5 Changed 7 years ago by arczi

  • Keywords Confirmed added

comment:6 Changed 7 years ago by alfonsoml

  • Summary changed from V3 - Implement basetag functionality to V3 - Implement baseHref functionality

comment:7 Changed 7 years ago by garry.yao

  • Owner set to garry.yao
  • Status changed from new to assigned

Depend on #4067.

Changed 7 years ago by garry.yao

comment:8 Changed 7 years ago by garry.yao

  • Keywords Review? added

Include the latest patch at #4067 for easy reviewing.

comment:9 Changed 7 years ago by garry.yao

#4664 has been marked as a DUP.

comment:10 Changed 7 years ago by fredck

  • Keywords Review- added; Review? removed

Let's have #4067 closed first at this point, having a new patch here for this tickets needs only.

comment:11 Changed 7 years ago by garry.yao

  • Keywords Review? added; Review- removed
  • Version set to SVN (CKEditor)

Review has to be conducted with the fullpage branch.

comment:12 Changed 7 years ago by fredck

  • Keywords Review- added; Review? removed

The basehref must also be active in the previews of the image and flash dialogs.

comment:13 Changed 7 years ago by fredck

The initial support for this feature has already been committed into the 3.1.x branch with [4636]. The fix for the above issue is still missing though, and this should be done through patches in this ticket now.

Changed 7 years ago by garry.yao

comment:14 Changed 7 years ago by garry.yao

  • Keywords Review? added; Review- removed
  • Status changed from assigned to new

Changed 7 years ago by garry.yao

comment:15 Changed 7 years ago by garry.yao

  • Status changed from new to assigned

3401_3 is unobtrusive while 3401_2.patch are just safer.

comment:16 Changed 7 years ago by fredck

  • Keywords Review- added; Review? removed

The 3401_2.patch is the way to go for me, but it throws "Permission denied" in IE when inserting an image, going to source and back, and opening the image dialog again. I think the previous previewImage DOM object is being used, but the editor.document has been destroyed and recreated.

3401_3.patch is not good instead. It's not working on all cases.

The following are the TCs I'm using:

URL: logo.gif
config.baseHref = 'http://www.google.com/intl/en_ALL/images/';
URL: ../images/logo.gif
config.baseHref = 'http://www.google.com/intl/en_ALL/images/';
URL: /intl/en_ALL/images/logo.gif
config.baseHref = 'http://www.google.com/intl/en_ALL/images/';
URL: http://www.google.com/intl/en_ALL/images/logo.gif
config.baseHref = 'http://www.yahoo.com/';

Changed 7 years ago by garry.yao

comment:17 Changed 7 years ago by garry.yao

  • Keywords Review? added; Review- removed

"Permission denied" in IE...I think...the editor.document has been destroyed and recreated.

True, but should be IE6 only, where cross document element is treated as a security risk.

3401_3.patch is not good instead.

I failed to take considering of the 3rd TCs.

Manual Test added at :
http://ckeditor.t/tt/3401/1.html.

comment:18 Changed 7 years ago by fredck

  • Keywords Review+ added; Review? removed

comment:19 Changed 7 years ago by garry.yao

  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed with [4665] at 3.1.x branch.

Note: See TracTickets for help on using tickets.
© 2003 – 2016 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy