Ticket #3412 (closed Bug: fixed)

Opened 6 years ago

Last modified 6 years ago

Dialog tab bar layout is wrong in IE6.

Reported by: martinkou Owned by: martinkou
Priority: Normal Milestone: CKEditor 3.0
Component: UI : Dialogs Version: SVN (CKEditor) - OLD
Keywords: Review+ Cc:

Description

To reproduce:

  1. Open replacebyclass.html in IE6.
  2. Open any dialog that has a tab bar (e.g. the image dialog).
  3. The tab bar is seen at a position about 10px lower than the intended location.

The bug occurs in both standards mode and quirks mode. But it doesn't affect IE7.

Attachments

3412.patch (5.8 KB) - added by martinkou 6 years ago.
dialog_layout.jpg (51.3 KB) - added by garry.yao 6 years ago.
Screen shot on Firefox2

Change History

comment:1 Changed 6 years ago by martinkou

  • Keywords Review? added

IE6 is getting confused by the ".cke_browser_gecko18.cke_skin_v2 ..." CSS declarations added in [3409]. So a bit of restructuring is needed for those CSS classes.

The patch puts the browser related CSS classes one level lower than the DIV containing the skin CSS class. The structural change affects CSS classes defined for other situations such as IE quirks mode and RTL dialogs.

So while testing this patch, be sure to review also:

  1. Quirks mode.
  2. IE6 and IE7.
  3. Firefox 2.
  4. RTL mode.

Changed 6 years ago by martinkou

Changed 6 years ago by garry.yao

Screen shot on Firefox2

comment:2 Changed 6 years ago by garry.yao

  • Keywords Review- added; Review? removed

Broken in FF2 as attached screen shot.

comment:3 Changed 6 years ago by garry.yao

  • Keywords Review+ added; Review- removed

The problem has already been fixed at #3362.

comment:4 Changed 6 years ago by martinkou

  • Status changed from new to closed
  • Resolution set to fixed

Fixed with [3412].

Click here for more info about our SVN system.

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy