Opened 7 years ago

Closed 7 years ago

#3427 closed Bug (fixed)

Correct synctax error of fck_docprops.html

Reported by: eerien Owned by: alfonsoml
Priority: Low Milestone: FCKeditor 2.6.5
Component: UI : Dialogs Version: FCKeditor 2.6.4
Keywords: Review+ Cc:

Description

link: http://www.fckeditor.net/forums/viewtopic.php?f=5&t=13718

In eclipse, editor/dialog/fck_docprops.html file shows errors. For correct the errors,

before - 459 line

                            <select id="selDocType" onchange="CheckOther( this, 'txtDocType' );">
                               <option value="" selected="selected"></option>
                               <option value='<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">'>HTML
                                  4.01 Transitional</option>
                               <option value='<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN" "http://www.w3.org/TR/html4/strict.dtd">'>
                                  HTML 4.01 Strict</option>
                               <option value='<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Frameset//EN" "http://www.w3.org/TR/html4/frameset.dtd">'>
                                  HTML 4.01 Frameset</option>
                               <option value='<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">'>
                                  XHTML 1.0 Transitional</option>
                               <option value='<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">'>
                                  XHTML 1.0 Strict</option>
                               <option value='<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Frameset//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-frameset.dtd">'>
                                  XHTML 1.0 Frameset</option>
                               <option value='<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN" "http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">'>
                                  XHTML 1.1</option>
                               <option value='<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2 Final//EN">'>HTML 3.2</option>
                               <option value='<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">'>HTML 2.0</option>
                               <option value="..." fcklang="DlgOpOther">&lt;Other&gt;</option>
                            </select>

after

                            <select id="selDocType" onchange="CheckOther( this, 'txtDocType' );">
                               <option value="" selected="selected"></option>
                               <option value='&lt;!DOCTYPE HTML PUBLIC &quot;-//W3C//DTD HTML 4.01 Transitional//EN&quot;&gt;'>HTML
                                  4.01 Transitional</option>
                               <option value='&lt;!DOCTYPE HTML PUBLIC &quot;-//W3C//DTD HTML 4.01//EN&quot; &quot;http://www.w3.org/TR/html4/strict.dtd&quot;&gt;'>
                                  HTML 4.01 Strict</option>
                               <option value='&lt;!DOCTYPE HTML PUBLIC &quot;-//W3C//DTD HTML 4.01 Frameset//EN&quot; &quot;http://www.w3.org/TR/html4/frameset.dtd&quot;&gt;'>
                                  HTML 4.01 Frameset</option>
                               <option value='&lt;!DOCTYPE html PUBLIC &quot;-//W3C//DTD XHTML 1.0 Transitional//EN&quot; &quot;http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd&quot;&gt;'>
                                  XHTML 1.0 Transitional</option>
                               <option value='&lt;!DOCTYPE html PUBLIC &quot;-//W3C//DTD XHTML 1.0 Strict//EN&quot; &quot;http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd&quot;&gt;'>
                                  XHTML 1.0 Strict</option>
                               <option value='&lt;!DOCTYPE html PUBLIC &quot;-//W3C//DTD XHTML 1.0 Frameset//EN&quot; &quot;http://www.w3.org/TR/xhtml1/DTD/xhtml1-frameset.dtd&quot;&gt;'>
                                  XHTML 1.0 Frameset</option>
                               <option value='&lt;!DOCTYPE html PUBLIC &quot;-//W3C//DTD XHTML 1.1//EN&quot; &quot;http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd&quot;&gt;'>
                                  XHTML 1.1</option>
                               <option value='&lt;!DOCTYPE HTML PUBLIC &quot;-//W3C//DTD HTML 3.2 Final//EN&quot;>'>HTML 3.2</option>
                               <option value='&lt;!DOCTYPE HTML PUBLIC &quot;-//IETF//DTD HTML//EN&quot;>'>HTML 2.0</option>
                               <option value="..." fcklang="DlgOpOther">&lt;Other&gt;</option>
                            </select>

Attachments (2)

2604.patch (1.3 KB) - added by alfonsoml 7 years ago.
Proposed patch
3427.patch (5.9 KB) - added by alfonsoml 7 years ago.
Proposed patch

Download all attachments as: .zip

Change History (7)

comment:1 Changed 7 years ago by alfonsoml

  • Keywords Review? added; fck_docprops.html removed
  • Owner set to alfonsoml
  • Status changed from new to assigned
  • Type changed from Task to Bug

The patch escapes the < and > inside the attributes, but that looks most like a bug in Eclipse. Besides that, it includes other little adjustments to avoid validation errors.

Changed 7 years ago by alfonsoml

Proposed patch

comment:2 Changed 7 years ago by martinkou

  • Keywords Review- added; Review? removed

Hmm... I think you've posted the wrong patch?

Changed 7 years ago by alfonsoml

Proposed patch

comment:3 Changed 7 years ago by alfonsoml

  • Keywords Review? added; Review- removed

This is the right one :-)

comment:4 Changed 7 years ago by martinkou

  • Keywords Review+ added; Review? removed

comment:5 Changed 7 years ago by alfonsoml

  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed with [3931]

Note: See TracTickets for help on using tickets.
© 2003 – 2016 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy