Ticket #3450 (closed Bug: fixed)

Opened 6 years ago

Last modified 5 years ago

[IE] Find result highlighting problem

Reported by: garry.yao Owned by: garry.yao
Priority: Normal Milestone: CKEditor 3.0
Component: General Version:
Keywords: IE IBM Confirmed Review+ Cc:

Description

Previous highlight marking style is not removed when search more than twice.

Reproducing Procedures

  1. Open the replace by class example page;
  2. Open 'Find' dialog, search for 'some';
  3. Keep the dialog open, another search for 'are'
  • Actual Result: Search results from both matching are marked.

Attachments

ie-find-highlight.png (25.1 KB) - added by tobiasz.cudnik 5 years ago.
IE8 strict
ie-find-highlight-2.png (22.0 KB) - added by tobiasz.cudnik 5 years ago.
IE8 strict
3450.patch (580 bytes) - added by garry.yao 5 years ago.
3450_2.patch (3.3 KB) - added by garry.yao 5 years ago.
3450_3.patch (4.6 KB) - added by garry.yao 5 years ago.
3450_4.patch (5.1 KB) - added by garry.yao 5 years ago.

Change History

comment:1 Changed 6 years ago by arczi

#3451 has been marked as DUP.

comment:2 Changed 5 years ago by garry.yao

  • Status changed from new to closed
  • Resolution set to fixed

Confirmed it been fixed with #3304.

comment:3 Changed 5 years ago by martinkou

  • Keywords IBM added

Changed 5 years ago by tobiasz.cudnik

IE8 strict

Changed 5 years ago by tobiasz.cudnik

IE8 strict

comment:4 Changed 5 years ago by tobiasz.cudnik

  • Status changed from closed to reopened
  • Resolution fixed deleted

I'm still able to reproduce this issue. Refer to attached screenshots.

comment:5 Changed 5 years ago by garry.yao

  • Keywords Confirmed added

Changed 5 years ago by garry.yao

comment:6 Changed 5 years ago by garry.yao

  • Keywords Review? added

Changed 5 years ago by garry.yao

comment:7 Changed 5 years ago by garry.yao

Proposing a more completed fix.

comment:8 Changed 5 years ago by tobiasz.cudnik

I can confirm that 3450_2.patch works for IE8.

comment:9 Changed 5 years ago by martinkou

  • Keywords Review- added; Review? removed

Two problems:

  1. The lowercase and semicolon fixes applied in getAttribute() are not effective.
  2. The whitespace fix in getAttribute() would break some CSS styles, e.g.
    border 1px solid red;
    

Changed 5 years ago by garry.yao

comment:10 Changed 5 years ago by garry.yao

  • Keywords Review? added; Review- removed

Remove the invalid 'white space fix' and reflect related TCs.

comment:11 Changed 5 years ago by garry.yao

  • Keywords Review? removed

Oops, style plugin changes is not included.

Changed 5 years ago by garry.yao

comment:12 Changed 5 years ago by garry.yao

  • Keywords Review? added

comment:13 Changed 5 years ago by martinkou

  • Keywords Review+ added; Review? removed

comment:14 Changed 5 years ago by martinkou

  • Status changed from reopened to new
  • Owner set to garry.yao

comment:15 follow-up: ↓ 16 Changed 5 years ago by fredck

I would avoid changes to CKEDITOR.dom.element as those are Style plugin specific.

comment:16 in reply to: ↑ 15 Changed 5 years ago by garry.yao

  • Status changed from new to assigned

Replying to fredck:

I would avoid changes to CKEDITOR.dom.element as those are Style plugin specific.

My motivation of this change is that normalize CKEDITOR.dom.element could remove many existed (even further) fixing around the style system, beside, style system's been a intrinsic component, which always loaded with core codes, I guess this fix not impacting too much of been moved into core.

comment:17 Changed 5 years ago by garry.yao

  • Status changed from assigned to closed
  • Resolution set to fixed

Fixed with [3517].

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy