Ticket #3494 (closed Bug: fixed)

Opened 5 years ago

Last modified 4 years ago

Context menu is too narrow in some translations

Reported by: arczi Owned by: alfonsoml
Priority: Normal Milestone: CKEditor 3.2
Component: UI : Floating Panel Version: SVN (CKEditor) - OLD
Keywords: Confirmed Review+ Cc:

Description

Context menu is too narrow in some translations. Please see attached image.

Attachments

3494.jpg (39.7 KB) - added by arczi 5 years ago.
3494.patch (2.1 KB) - added by alfonsoml 4 years ago.
Partial patch
3494_2.patch (3.9 KB) - added by alfonsoml 4 years ago.
Context menu patch

Change History

Changed 5 years ago by arczi

comment:1 Changed 5 years ago by fredck

  • Keywords Confirmed added
  • Milestone changed from CKEditor 3.0 to CKEditor 3.1

We should have auto-width for the menus, just like V2.

comment:2 Changed 5 years ago by fredck

#4034 has been marked as DUP.

comment:3 Changed 4 years ago by fredck

#4568 has been marked as DUP.

comment:4 Changed 4 years ago by fredck

  • Milestone changed from CKEditor 3.1 to CKEditor 3.2

comment:5 Changed 4 years ago by alfonsoml

  • Status changed from new to assigned
  • Owner set to alfonsoml

Changed 4 years ago by alfonsoml

Partial patch

comment:6 Changed 4 years ago by alfonsoml

  • Keywords Review? added

I would like to know if the current approach for the patch is right.

Making it work for Firefox, Opera and Safari is quite straight forward, but IE is quite different as expected: if the panel is loaded with the alpha opacity filter applied, then the elements don't overflow, so it's not possible to get their real scrollWidth. In order to workaround that, I have moved that attributes in the kama skin to a new rule with a class that it's set only after the width has been computed.

I haven't tried to test thoroughly the patch, I just want to know if the coding looks OK or if it can be done in a better way. In the skin I've disabled also the _width rule for IE6, I think that the _overflow can be removed also, I'll test that approach for the final patch unless someone states a reason why they might be required.

comment:7 Changed 4 years ago by garry.yao

  • Keywords Review- added; Review? removed
  • Version set to SVN (CKEditor)
  • Component changed from General to UI : Floating Panel

The patch works well for me with the following limitations:

  1. Doesn't work for other panels (combobox);
  2. Doesn't work in Safari;

comment:8 Changed 4 years ago by alfonsoml

I was focusing just on the context menu, as I thought that other panels are discussed in #4559 Should I work also on that? It could be a matter of moving this new code outside of the if ( block.autoSize ) check but I don't want to do it if that's not the expected behavior.

A last minute change broke compatibility with Safari, but as I said I was more worried about the structure of the code (changing the skin to include a new class in the frame). If that's ok, I'll work to review that it works properly in all browsers.

Thanks for the comments.

Changed 4 years ago by alfonsoml

Context menu patch

comment:9 Changed 4 years ago by alfonsoml

  • Keywords Review? added; Review- removed

The patch covers only the context menu. I've tried to make it work for other floating panels, but I can't find what's messing there with the widths in IE, I'm not able to make it work, so I propose to fix the context menu for the moment and focus later in the rest of panels.

I've tested it quickly in RTL as I don't know which language might have long translations for the context menu.

comment:10 Changed 4 years ago by garry.yao

  • Keywords Review+ added; Review? removed

The patch works well for context menu.

comment:11 Changed 4 years ago by alfonsoml

  • Status changed from assigned to closed
  • Resolution set to fixed

Fixed with [5047]

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy