Opened 8 years ago

Closed 8 years ago

#3500 closed Bug (fixed)

Failed testcase dom.element test_getAttribute_ignoreExpandoAttributes

Reported by: alfonsoml Owned by: fredck
Priority: Normal Milestone: CKEditor 3.0
Component: General Version: SVN (CKEditor) - OLD
Keywords: Review+ Cc:


Except IE8 all the browsers fail this test.

In IE7 it's due to the testcase itself, the rest of the browsers are failing because they return the _cke_expando as an attribute (just what the test is checking)

The patch fixes all the issues for me.

Attachments (2)

3500.patch (1.8 KB) - added by alfonsoml 8 years ago.
Proposed patch
3500_2.patch (2.0 KB) - added by fredck 8 years ago.

Download all attachments as: .zip

Change History (6)

Changed 8 years ago by alfonsoml

Proposed patch

comment:1 Changed 8 years ago by fredck

  • Keywords Review- added; Review? removed
  • Owner changed from alfonsoml to fredck
  • Status changed from new to assigned

The TC could be a bit simpler. Also, in the case of tabIndex, it's not a matter of making the test pass. Tests should identify possible weak points, so the right fix would be making it work properly with tabindex.

I'll come with a new patch for it.

Changed 8 years ago by fredck

comment:2 Changed 8 years ago by fredck

  • Keywords Review? added; Review- removed

comment:3 Changed 8 years ago by garry.yao

  • Keywords Review+ added; Review? removed

comment:4 Changed 8 years ago by fredck

  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed with [3487].

Note: See TracTickets for help on using tickets.
© 2003 – 2017 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy