Opened 8 years ago
Closed 7 years ago
#3517 closed Bug (fixed)
"Match cyclic" field in Find & Replace dialog
| Reported by: | tobiasz.cudnik | Owned by: | tobiasz.cudnik |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.1 |
| Component: | General | Version: | |
| Keywords: | Confirmed Review+ | Cc: |
Description
I'm not sure if i understand correctly what "Match cyclic" should do, but if this is something like "Wrap search" or "Search from beginning after file end" then it acts in opposite way.
TC
- Use following content:
<p> This is some <strong>sample text</strong>. You are using^ <a href="http://www.fckeditor.net/">CKEditor</a>.</p>
- Search "are" with "Match cyclic" checked on. Nothing happens.
- Search "are" again, now with "Match cyclic" checked OFF. Now the text will be found.
Reproduced using r3500 in FF3, IE8.
Attachments (2)
Change History (10)
comment:1 Changed 8 years ago by fredck
- Milestone changed from CKEditor 3.0 to CKEditor 3.1
comment:2 Changed 8 years ago by garry.yao
- Keywords Confirmed added
comment:3 Changed 7 years ago by tobiasz.cudnik
- Owner set to tobiasz.cudnik
- Status changed from new to assigned
Changed 7 years ago by tobiasz.cudnik
comment:4 Changed 7 years ago by tobiasz.cudnik
- Keywords Review? added
Patch adds little recursion (the safe one) which allows to find searched text in first run, when searched text is before cursor and "match cyclic" is turned on.
comment:5 Changed 7 years ago by garry.yao
- Keywords Review- added; Review? removed
The recursion once idea is great, while the codes could be further simplified.
Changed 7 years ago by garry.yao
comment:6 Changed 7 years ago by tobiasz.cudnik
- Keywords Review? added; Review- removed
I was missing this neat Array.prototype trick, thanks.
I'm adding Review? for 3517_2.patch.
comment:7 Changed 7 years ago by garry.yao
- Keywords Review+ added; Review? removed
comment:8 Changed 7 years ago by tobiasz.cudnik
- Resolution set to fixed
- Status changed from assigned to closed
Fixed with [4193].
Note: See
TracTickets for help on using
tickets.
The 'cyclic' option means to have effect only after your already reached document end once, yes, it's reasonable to have it work right from the beginning.