Reload SCAYT before insertElement

[Artur Formella]

Steps to reproduce:

-Enable SCAYT plugin -Insert "mmmmmmmmmmmmmmmmmmmmmmm" -Put cursor in the middle of this word. -Insert smile using the dialog ( mmmmmmm :D mmmmmmm ) . -Click on the first word to open context menu and click any of the suggestions.

Result: The whole SPAN was replaced and smile is missing. Expected result: only part of the word is replaced with the suggestion.

[Artur Formella]

#3569 has been marked as DUP

[Artur Formella]

It must be fixed before #3560

[Artur Formella]

Local "var scayt" was changed into "var instance" because scayt is a global variable.

Patch doesn't fix #3569. This bug seems to be in the scayt engine.

[Garry Yao]

I wonder if we need to reset the scayt instance:

instance.reset();
instance.setDisabled( false );

Does it work if we only refresh the scayt after insertElement with instnace.refresh()?
And not sure why unlock the selection is necessary.

[Artur Formella]

instance.refresh() doesn't work in this case, I don't know when it works.

instance.reset(); is to disable SCAYT (instance.setDisabled( true ); also can be used) instance.setDisabled( false ); is to enable SCAYT

editor.getSelection().unlock(); is used because of the JS error:

selection/plugin.js line 926

ieRange.moveToElementText( startNode.$ );

called in

if ( CKEDITOR.env.ie )
	editor.getSelection().unlock( true );

in dialog.hide(); in smiley plugin

Patch was very old so I made a new.

[Garry Yao]

It's possible that by calling 'scayt.reset' will change the DOM structure and thus break the selection within editor, so can you try if creating a bookmark will help in this sense? Anyway, after discuss with Artur, we found that we need more knowledge regarding SCAYT engine at API level at least to bring those changes, the reviewing of this ticket will be defered after we have a communication with SpellChecker.net.

[Artur Formella]

#3839 fixes this bug.