Opened 7 years ago

Closed 6 years ago

#3570 closed New Feature (fixed)

Elementpath work with SCAYT

Reported by: garry.yao Owned by: garry.yao
Priority: Normal Milestone: CKEditor 3.3
Component: UI : Spell Checker Version: SVN (CKEditor) - OLD
Keywords: Confirmed Review+ Cc: SpellChecker.net

Description

Elementpath should hide SCAYT marker '<span>' from end user.

Attachments (2)

3570.patch (1.1 KB) - added by fredck 6 years ago.
3570_2.patch (5.4 KB) - added by garry.yao 6 years ago.

Download all attachments as: .zip

Change History (16)

comment:1 Changed 7 years ago by arczi

  • Keywords Confirmed added

comment:2 Changed 6 years ago by SpellChecker.net

  • Resolution set to fixed
  • Status changed from new to closed

patch is submitted in #5145

comment:3 Changed 6 years ago by fredck

  • Resolution fixed deleted
  • Status changed from closed to reopened

It's ok to indicate that this one is supposed to be fixed by another tickets, but it should be closed only after confirming the fix one the relative ticket gets closed.

Changed 6 years ago by fredck

comment:4 Changed 6 years ago by fredck

  • Keywords Review? added
  • Milestone changed from CKEditor 3.x to CKEditor 3.2

comment:5 Changed 6 years ago by fredck

  • Owner set to fredck
  • Status changed from reopened to new

comment:6 Changed 6 years ago by fredck

  • Status changed from new to assigned

comment:7 Changed 6 years ago by fredck

  • Keywords Review? removed
  • Milestone changed from CKEditor 3.2 to CKEditor 3.3

Maybe it's better to have a generic solution for it, like having a standard attribute to be appended to elements to be ignored in the elements path.

Changed 6 years ago by garry.yao

comment:8 Changed 6 years ago by garry.yao

  • Cc SpellChecker.net added
  • Keywords Review? added
  • Version set to SVN (CKEditor)

Introduce a generic config option for achieving that.

comment:9 Changed 6 years ago by SpellChecker.net

Here is idea. Does it make a sence to add some method to the Elementpath which allow to register set of keys which should be taken into account when Elementpath works. There should be ability to unregister this set of keys. This method can be called from plug-ins.

Ignore(
{/*String*/ param1: /*String*/value1,
 /*String*/ param2: /*String*/value2,
 ...
}

where

paramX - property name | attribute name valueX - value or part of value which paramX may contain or null which means that paramX should be checked for existance

Samples:

Ignore(
{
  "scaytid": null
});

or

Ignore(
{
  "nodeName": "span",
  "class": "ignore"
});

or

if on the page <b> is suppressed by the style:

b { font-weight: normal }

and only <strong> should be displayed then Ignore method can be called following way:

Ignore(
{
  "nodeName": "b"
});

comment:10 Changed 6 years ago by garry.yao

The provided patch could achieve that: config.elementsPath_filters.push( function( element ) {

if( element.is( 'b' ) && element.getComputedStyle( 'font-weight' ) == 'normal' ) )

return false;

});

comment:11 Changed 6 years ago by garry.yao

  • Owner changed from fredck to garry.yao
  • Status changed from assigned to new

comment:12 Changed 6 years ago by alfonsoml

  • Keywords Review+ added; Review? removed

In the documentation it's written once 'myAttribue', just fix that before committing.

comment:13 Changed 6 years ago by garry.yao

  • Status changed from new to assigned

Fixed with [5228].

comment:14 Changed 6 years ago by garry.yao

  • Resolution set to fixed
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.
© 2003 – 2016 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy