Opened 16 years ago
Closed 15 years ago
#3570 closed New Feature (fixed)
Elementpath work with SCAYT
Reported by: | Garry Yao | Owned by: | Garry Yao |
---|---|---|---|
Priority: | Normal | Milestone: | CKEditor 3.3 |
Component: | UI : Spell Checker | Version: | SVN (CKEditor) - OLD |
Keywords: | Confirmed Review+ | Cc: | WebSpellChecker.net |
Description
Elementpath should hide SCAYT marker '<span>' from end user.
Attachments (2)
Change History (16)
comment:1 Changed 16 years ago by
Keywords: | Confirmed added |
---|
comment:2 Changed 15 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:3 Changed 15 years ago by
Resolution: | fixed |
---|---|
Status: | closed → reopened |
It's ok to indicate that this one is supposed to be fixed by another tickets, but it should be closed only after confirming the fix one the relative ticket gets closed.
Changed 15 years ago by
Attachment: | 3570.patch added |
---|
comment:4 Changed 15 years ago by
Keywords: | Review? added |
---|---|
Milestone: | CKEditor 3.x → CKEditor 3.2 |
comment:5 Changed 15 years ago by
Owner: | set to Frederico Caldeira Knabben |
---|---|
Status: | reopened → new |
comment:6 Changed 15 years ago by
Status: | new → assigned |
---|
comment:7 Changed 15 years ago by
Keywords: | Review? removed |
---|---|
Milestone: | CKEditor 3.2 → CKEditor 3.3 |
Maybe it's better to have a generic solution for it, like having a standard attribute to be appended to elements to be ignored in the elements path.
Changed 15 years ago by
Attachment: | 3570_2.patch added |
---|
comment:8 Changed 15 years ago by
Cc: | WebSpellChecker.net added |
---|---|
Keywords: | Review? added |
Version: | → SVN (CKEditor) |
Introduce a generic config option for achieving that.
comment:9 Changed 15 years ago by
Here is idea. Does it make a sence to add some method to the Elementpath which allow to register set of keys which should be taken into account when Elementpath works. There should be ability to unregister this set of keys. This method can be called from plug-ins.
Ignore( {/*String*/ param1: /*String*/value1, /*String*/ param2: /*String*/value2, ... }
where
paramX - property name | attribute name valueX - value or part of value which paramX may contain or null which means that paramX should be checked for existance
Samples:
Ignore( { "scaytid": null });
or
Ignore( { "nodeName": "span", "class": "ignore" });
or
if on the page <b> is suppressed by the style:
b { font-weight: normal }
and only <strong> should be displayed then Ignore method can be called following way:
Ignore( { "nodeName": "b" });
comment:10 Changed 15 years ago by
The provided patch could achieve that: config.elementsPath_filters.push( function( element ) {
if( element.is( 'b' ) && element.getComputedStyle( 'font-weight' ) == 'normal' ) )
return false;
});
comment:11 Changed 15 years ago by
Owner: | changed from Frederico Caldeira Knabben to Garry Yao |
---|---|
Status: | assigned → new |
comment:12 Changed 15 years ago by
Keywords: | Review+ added; Review? removed |
---|
In the documentation it's written once 'myAttribue', just fix that before committing.
comment:14 Changed 15 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
patch is submitted in #5145