Bad performance at resizing editor in Safari

[Martin Kou]

To reproduce:

1. Open replacebyclass.html in Safari/Windows.
2. Resize the editor.
3. The resize animation is not smooth.

The bad performance seems to be Windows specific, it seems to be perfectly smooth in Safari/Mac.

[Garry Yao]

We should really consider using proxy, even for other browsers.

[Garry Yao]

I don't see the described problem in that part of codes on Windows, which slows down the resizing, can somebody confirm it on Mac?

[Alfonso Martínez de Lizarrondo]

I've applied the patch and I don't see any bad performance or crash as the comments stated, tested with Windows and Mac OS X 10.6.3 with Safari 4.0.5 and Chrome

But due to the crash comment I would prefer for someone else to test and verify that there are no problems by removing that code.

[Frederico Caldeira Knabben]

WFM also, on Mac and Win. It may be related to an old version of Safari. Here is the original comment that introduced that fix: comment:ticket:3564:7.

In the comment I'm stating that the issue affected both Safari 3 and 4. So, even if we're testing only with Safari 4, we should be ok with it (I mean, it was not a Safari 3 only issue).

[Garry Yao]

Fixed with [5379].

[Alfonso Martínez de Lizarrondo]

That code is needed because now it has triggered #5729

[Frederico Caldeira Knabben]

I've reverted [5379] with [5516], because it's bringing a strong issue, as described in #5729.

[Garry Yao]

The patch proposes introduce a 'resize_proxy' configuration, which by default set to true for for browsers that have performance/layout problem when doing live-resize.

[Alfonso Martínez de Lizarrondo]

As the summary stated the performance problems are only for Safari & Windows. Safari on Mac behaves correctly. Chrome on Windows and Mac also seem to behave quite well for me.

The documentation for config.resize_proxy has been placed before the declaration for config.resize_dir

If the user sets config.resize_proxy=false, it will still be enabled for Safari & IE6.

The IE check will enable the proxy for IE7, although the comment states IE6.

[Alfonso Martínez de Lizarrondo]

A suggestion: instead of naming this "resize_proxy" that might look strange, what about something like "liveResizePreview" ?

[Garry Yao]

Decent review, new patch targeting the above points.

[Frederico Caldeira Knabben]

I'm not reviewing it now. Please note that the configuration must be named "resize_livePreview", not "resize_livepreview".

[Pablo Vanwoerkom]

So is this fixed on 3.6.2?

[Piotrek Koszuliński]

I cannot reproduce any issue on latest Safari. Works like a charm.