Opened 7 years ago

Closed 7 years ago

Last modified 6 years ago

#3639 closed Bug (fixed)

Button size inconsistency

Reported by: garry.yao Owned by: tobiasz.cudnik
Priority: Normal Milestone: CKEditor 3.0
Component: UI : Dialogs Version:
Keywords: Kama Confirmed Review+ Cc:

Description

The size of different dialog buttons should be the same.

Attachments (6)

IE6.png (673 bytes) - added by garry.yao 7 years ago.
Screenshot of IE6
FF3.png (2.2 KB) - added by garry.yao 7 years ago.
Screenshot of FF3
3639.patch (917 bytes) - added by arczi 7 years ago.
3639_2.patch (2.6 KB) - added by tobiasz.cudnik 7 years ago.
IE6+Standards_Too_Large.png (28.5 KB) - added by fredck 7 years ago.
IE6+Patch Screenshot.
3639_3.patch (3.1 KB) - added by tobiasz.cudnik 7 years ago.

Download all attachments as: .zip

Change History (15)

Changed 7 years ago by garry.yao

Screenshot of IE6

Changed 7 years ago by garry.yao

Screenshot of FF3

Changed 7 years ago by arczi

comment:1 Changed 7 years ago by arczi

  • Keywords Confirmed Review? added

comment:2 Changed 7 years ago by tobiasz.cudnik

  • Keywords Review- added; Review? removed

Still not wide enough in IE7 quirks (using IE8) - screenshot.

comment:3 Changed 7 years ago by tobiasz.cudnik

  • Owner set to tobiasz.cudnik
  • Status changed from new to assigned

Changed 7 years ago by tobiasz.cudnik

comment:4 Changed 7 years ago by tobiasz.cudnik

  • Keywords Review? added; Review- removed

comment:5 Changed 7 years ago by fredck

  • Keywords Review- added; Review? removed

With the IE6+Standards combination, the buttons are too large. I'm attaching a screenshot of it.

In Safari, the sizes are also not good. Their height is wrong.

Ok with other browsers, including IE6+Quirks.

Changed 7 years ago by fredck

IE6+Patch Screenshot.

Changed 7 years ago by tobiasz.cudnik

comment:6 Changed 7 years ago by tobiasz.cudnik

  • Keywords Review? added; Review- removed

comment:7 Changed 7 years ago by arczi

  • Keywords Review+ added; Review? removed

Looks good...

comment:8 Changed 7 years ago by tobiasz.cudnik

  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed with [3799].

comment:9 Changed 6 years ago by alfonsoml

I don't know why the float:right was added for webkit, but now all the buttons in the dialogs are right aligned for Safari and Chrome: #4748

Note: See TracTickets for help on using tickets.
© 2003 – 2016 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy