Ticket #3644 (closed Bug: fixed)

Opened 5 years ago

Last modified 5 years ago

Image dialog missing radio lock

Reported by: garry.yao Owned by: tobiasz.cudnik
Priority: Normal Milestone: CKEditor 3.0
Component: UI : Dialogs Version:
Keywords: IE Review+ Cc:

Description


Attachments

FF3.png (22.9 KB) - added by garry.yao 5 years ago.
Screenshot of FF3
3644.patch (8.5 KB) - added by arczi 5 years ago.
Patch for CKEditor/branches/features/kama/
3644_2.patch (4.7 KB) - added by tobiasz.cudnik 5 years ago.
3644_3.patch (5.4 KB) - added by tobiasz.cudnik 5 years ago.

Change History

Changed 5 years ago by garry.yao

Screenshot of FF3

comment:1 Changed 5 years ago by arczi

  • Keywords Confirmed added

comment:2 Changed 5 years ago by arczi

  • Owner set to arczi
  • Status changed from new to assigned

I think [3512] should be added into Kama branch.

Changed 5 years ago by arczi

Patch for CKEditor/branches/features/kama/

comment:3 Changed 5 years ago by arczi

  • Keywords Review? added

comment:4 Changed 5 years ago by garry.yao

  • Keywords Review+ added; Review? removed

comment:5 Changed 5 years ago by arczi

  • Status changed from assigned to new
  • Owner changed from arczi to tobiasz.cudnik

comment:6 Changed 5 years ago by tobiasz.cudnik

  • Status changed from new to closed
  • Resolution set to fixed

This seems to be already fixed in kama branch, somewhere before r3641.

comment:7 Changed 5 years ago by garry.yao

  • Status changed from closed to reopened
  • Keywords IE added; Kama Confirmed Review+ removed
  • Resolution fixed deleted

The ratio lock is still missing in IE6.

Changed 5 years ago by tobiasz.cudnik

comment:8 Changed 5 years ago by tobiasz.cudnik

  • Keywords Review? added

comment:9 Changed 5 years ago by fredck

  • Summary changed from Image dialog missin radio lock to Image dialog missing radio lock

comment:10 Changed 5 years ago by fredck

  • Keywords Review- added; Review? removed

The image dialog layout becomes broken in IE7+Quirks with the patch, much probably because of the float rule changes.

Changed 5 years ago by tobiasz.cudnik

comment:11 Changed 5 years ago by tobiasz.cudnik

  • Keywords Review? added; Review- removed

I've took a bit other way in second patch, which seems safer. I've removed floats change, although it didn't created any issues in my case on IE7 quirks.

comment:12 Changed 5 years ago by fredck

  • Keywords Review+ added; Review? removed

comment:13 Changed 5 years ago by tobiasz.cudnik

  • Status changed from reopened to closed
  • Resolution set to fixed

Fixed with [3953].

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy