Opened 17 years ago
Closed 16 years ago
#3664 closed Bug (fixed)
Insert table in empty document add extra line
| Reported by: | Garry Yao | Owned by: | Garry Yao |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.1 |
| Component: | Core : Styles | Version: | |
| Keywords: | Confirmed HasTest Review+ | Cc: |
Description (last modified by )
Reproducing Procedures
- Open the replace by class example page in FF;
- Click on 'New Page' to empty the document;
- Insert a default table;
- Expected Result:
<table border="1" cellpadding="1" cellspacing="1" style="width: 200px;"> ... </table> <p> <br /> </p>
- Actual Result: There's an paragraph established before the table:
<p> <br /> </p> <table border="1" cellpadding="1" cellspacing="1" style="width: 200px;"> ... </table> <p> <br /> </p>
- Expected Result:
Attachments (3)
Change History (15)
Changed 17 years ago by
| Attachment: | 3664.patch added |
|---|
comment:1 Changed 17 years ago by
| Description: | modified (diff) |
|---|
comment:2 Changed 17 years ago by
| Keywords: | Review? added |
|---|---|
| Status: | new → assigned |
comment:3 follow-up: 7 Changed 16 years ago by
With this patch it is not possible to insert anything above the table.
comment:4 Changed 16 years ago by
| Keywords: | Review- added; Review? removed |
|---|
The right way to check if we're in an empty block is by checking if the range is checkStartOfBlock "and" checkEndOfBlock.
comment:5 Changed 16 years ago by
| Milestone: | CKEditor 3.0 → CKEditor 3.1 |
|---|
comment:6 Changed 16 years ago by
| Keywords: | HasTest Review? added; Review- removed |
|---|
Ticket Test added at : http://ckeditor.t/tt/3664/1.html.
Changed 16 years ago by
| Attachment: | 3664_2.patch added |
|---|
comment:7 Changed 16 years ago by
Replying to arczi:
With this patch it is not possible to insert anything above the table.
The exitable table feature is a separate topic and should be handled by other tickets, the patch is about that.
comment:8 Changed 16 years ago by
| Keywords: | Review- added; Review? removed |
|---|
- The "children", "count", "firstChild" are still in the code (not used).
- The "if" declaration at line 85 is missing the curly braces.
Changed 16 years ago by
| Attachment: | 3664_3.patch added |
|---|
comment:9 Changed 16 years ago by
| Keywords: | Review? added; Review- removed |
|---|
comment:10 Changed 16 years ago by
| Keywords: | Review+ added; Review? removed |
|---|
comment:12 Changed 16 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |

Not sure if we need to trim the last paragraph, so keep it in the expected result.