Opened 8 years ago
Closed 8 years ago
#3742 closed Bug (fixed)
[IE] Wrong dialog layout for dialogs without tab bar in IE RTL mode
| Reported by: | martinkou | Owned by: | tobiasz.cudnik |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.0 |
| Component: | UI : Dialogs | Version: | SVN (CKEditor) - OLD |
| Keywords: | IE Confirmed Review+ | Cc: |
Description
Screencast video:
Attachments (7)
Change History (16)
comment:1 Changed 8 years ago by tobiasz.cudnik
- Keywords IE Confirmed added
- Owner changed from martinkou to tobiasz.cudnik
- Status changed from new to assigned
- Summary changed from Wrong dialog layout for dialogs without tab bar in IE RTL mode to [IE] Wrong dialog layout for dialogs without tab bar in IE RTL mode
Changed 8 years ago by tobiasz.cudnik
comment:2 Changed 8 years ago by tobiasz.cudnik
- Keywords Review? added
Changed 8 years ago by fredck
comment:3 Changed 8 years ago by fredck
- Keywords Review- added; Review? removed
Changed 8 years ago by tobiasz.cudnik
comment:4 Changed 8 years ago by tobiasz.cudnik
- Keywords Review? added; Review- removed
Patch makes dialog close button working on all IE versions, but rendered dialog aren't pixel-to-pixel identical. In some places they differs in space width.
Changed 8 years ago by tobiasz.cudnik
comment:5 Changed 8 years ago by tobiasz.cudnik
Third patch seems to resolve this issue.
comment:6 Changed 8 years ago by fredck
- Keywords Review- added; Review? removed
Well, if we're supposed to fix it, let's do it the right way, and just once.
I'm attaching new screenshots. Please test it properly before providing a new patch.
Changed 8 years ago by fredck
Changed 8 years ago by tobiasz.cudnik
comment:7 Changed 8 years ago by tobiasz.cudnik
- Keywords Review? added; Review- removed
I'm proposing new patch which seems to work well for both close button and tabs space in all IE modes.
I'm attaching screenshots presenting dialogs with and without tabs in all IE modes.
comment:8 Changed 8 years ago by fredck
- Keywords Review+ added; Review? removed
Please add also the following to dialog.css (line 519) when committing:
.cke_skin_kama .cke_browser_ie6 .cke_dialog_close_button,
.cke_skin_kama .cke_browser_iequirks .cke_dialog_close_button
{
top: 7px;
}
This will fix the close button position on IE Quirks and IE6.
comment:9 Changed 8 years ago by tobiasz.cudnik
- Resolution set to fixed
- Status changed from assigned to closed
Fixed with [3858]. I've included the 2px fix for IE Quirks and IE6.

Things are still not good with the new patch. I'm attaching screenshots takes with all IE variations that shows the problems.
The screenshots are based on a test page I have locally. It should the editor in LTR and RTL (left and right panes), and Standards and Quirks (top and bottom panes).