Ticket #3785 (closed Bug: fixed)

Opened 6 years ago

Last modified 5 years ago

[IE8] CKEDITOR.tools.htmlEncode returns NBSPs in IE8

Reported by: martinkou Owned by: tobiasz.cudnik
Priority: Normal Milestone: CKEditor 3.0
Component: General Version: SVN (CKEditor) - OLD
Keywords: IE Confirmed Review+ Cc:

Description (last modified by tobiasz.cudnik) (diff)

CKEDITOR.tools.htmlEncode returns NBSPs in IE8.

Smiley dialog layout is wrong

To reproduce:

  1. Open smiley dialog in IE8.
  2. The table containing the icons does not fill the dialog.

Snippet

CKEDITOR.tools.htmlEncode('  ')

Attachments

3785.patch (730 bytes) - added by tobiasz.cudnik 5 years ago.
Quickfix
3785_2.patch (845 bytes) - added by tobiasz.cudnik 5 years ago.

Change History

comment:1 Changed 5 years ago by tobiasz.cudnik

  • Status changed from new to assigned
  • Owner set to tobiasz.cudnik

Changed 5 years ago by tobiasz.cudnik

Quickfix

Changed 5 years ago by tobiasz.cudnik

comment:2 Changed 5 years ago by tobiasz.cudnik

  • Keywords IE Confirmed Review? added
  • Component changed from UI : Dialogs to General
  • Description modified (diff)
  • Summary changed from Smiley dialog layout is wrong in IE8. to [IE8] CKEDITOR.tools.htmlEncode returns NBSPs in IE8

The reason was deep in CKEDITOR.tools.htmlEncode(), which relays on browser-borowed code.

comment:3 Changed 5 years ago by garry.yao

  • Keywords Review+ added; Review? removed

Pretty nice fix, but seems not need to create two variable( fix1, fix2 ) for it. And please join the comments one L244 with L245.

comment:4 Changed 5 years ago by tobiasz.cudnik

  • Status changed from assigned to closed
  • Resolution set to fixed

Fixed with [3768].

@Garry: Local variables you mentioned are needed, without it or using only one, we will have stack overflow (at least in IE8).

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy