Opened 16 years ago
Closed 16 years ago
#3785 closed Bug (fixed)
[IE8] CKEDITOR.tools.htmlEncode returns NBSPs in IE8
| Reported by: | Martin Kou | Owned by: | Tobiasz Cudnik |
|---|---|---|---|
| Priority: | Normal | Milestone: | CKEditor 3.0 |
| Component: | General | Version: | SVN (CKEditor) - OLD |
| Keywords: | IE Confirmed Review+ | Cc: |
Description (last modified by )
CKEDITOR.tools.htmlEncode returns NBSPs in IE8.
Smiley dialog layout is wrong
To reproduce:
- Open smiley dialog in IE8.
- The table containing the icons does not fill the dialog.
Snippet
CKEDITOR.tools.htmlEncode(' ')
Attachments (2)
Change History (6)
comment:1 Changed 16 years ago by
| Owner: | set to Tobiasz Cudnik |
|---|---|
| Status: | new → assigned |
Changed 16 years ago by
| Attachment: | 3785.patch added |
|---|
Changed 16 years ago by
| Attachment: | 3785_2.patch added |
|---|
comment:2 Changed 16 years ago by
| Component: | UI : Dialogs → General |
|---|---|
| Description: | modified (diff) |
| Keywords: | IE Confirmed Review? added |
| Summary: | Smiley dialog layout is wrong in IE8. → [IE8] CKEDITOR.tools.htmlEncode returns NBSPs in IE8 |
The reason was deep in CKEDITOR.tools.htmlEncode(), which relays on browser-borowed code.
comment:3 Changed 16 years ago by
| Keywords: | Review+ added; Review? removed |
|---|
Pretty nice fix, but seems not need to create two variable( fix1, fix2 ) for it. And please join the comments one L244 with L245.
comment:4 Changed 16 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Fixed with [3768].
@Garry: Local variables you mentioned are needed, without it or using only one, we will have stack overflow (at least in IE8).
Note: See
TracTickets for help on using
tickets.
Quickfix