Opened 7 years ago

Closed 7 years ago

#3789 closed Bug (fixed)

Duplicate "src" attribute in image input type element

Reported by: wwalc Owned by: arczi
Priority: Normal Milestone: CKEditor 3.0
Component: General Version:
Keywords: Confirmed Review+ Cc:

Description

Create image button and you'll see:

<input alt="" src="http://a.cksource.com/a/1/gfx/logo_ck_editor.png" src="http://a.cksource.com/a/1/gfx/logo_ck_editor.png" type="image" />

(the "src" attribute is repeated).

Attachments (2)

3789.patch (646 bytes) - added by arczi 7 years ago.
3789_2.patch (2.1 KB) - added by arczi 7 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 7 years ago by arczi

  • Owner set to arczi
  • Status changed from new to assigned

Changed 7 years ago by arczi

comment:2 Changed 7 years ago by arczi

  • Keywords Confirmed Review? added

comment:3 Changed 7 years ago by garry.yao

  • Keywords Review- added; Review? removed

The 'name' and 'src' protecting logic is currently causing a lot of code DUP, adding a new rule for this purpose is preferred, e.g.

	var defaultHtmlAttirubteRules =
	{
		elements : {
			$ : function( element )
			{
				var attribs = element.attribs;
				if ( attribs && attribs._cke_saved_name )
					delete attribs.name;
				if ( attribs && attribs._cke_saved_href )
					delete attribs.href;
			}
		}
	};

Changed 7 years ago by arczi

comment:4 Changed 7 years ago by arczi

  • Keywords Review? added; Review- removed

comment:5 Changed 7 years ago by garry.yao

  • Keywords Review+ added; Review? removed

comment:6 Changed 7 years ago by fredck

  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed with [3778].

Note: See TracTickets for help on using tickets.
© 2003 – 2016 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy