Ticket #3810 (closed Bug: fixed)

Opened 5 years ago

Last modified 5 years ago

IE: Template throws error

Reported by: fredck Owned by: garry.yao
Priority: Normal Milestone: CKEditor 3.0
Component: General Version: SVN (CKEditor) - OLD
Keywords: Confirmed IE Review? WorksForMe Cc:

Description

With IE, a js error is thrown when using the Template button, after selecting one of the templates.

Attachments

3810.patch (1.9 KB) - added by garry.yao 5 years ago.

Change History

comment:1 Changed 5 years ago by garry.yao

  • Owner set to garry.yao
  • Status changed from new to assigned

Problem comes from 'CKEDITOR.editor::setData'.

Changed 5 years ago by garry.yao

comment:2 Changed 5 years ago by garry.yao

  • Keywords Review? added

Again, coz CKEDITOR.editor::setData is sync, unlock selection ( invoked in dialog.hide ) for IE will result in error, the only event we can relay on now is contentDom, so I make the changes to template plugin.
Then, I found the editor is still not gaining focus within the event handler, and that's because contentDom is fired too early to gain document focus.( Focus is locked by 'isLoadingData')Ok, so let's make the event happened later, result in such a ugly fix.

comment:3 Changed 5 years ago by arczi

  • Keywords WorksForMe added

This bug seems to be fixed with [3794]

comment:4 Changed 5 years ago by fredck

  • Status changed from assigned to closed
  • Resolution set to fixed

Yes, it's not anymore an issue with the current trunk.

Note: See TracTickets for help on using tickets.
© 2003 – 2012 CKSource – Frederico Knabben. All rights reserved. | Terms of use | Privacy policy