Opened 15 years ago

Closed 15 years ago

Last modified 15 years ago

#3812 closed Bug (fixed)

CKEditor's editor area is not editable in IE8/IE7 and no data is displayed in Firefox

Reported by: Senthil Owned by: Martin Kou
Priority: Must have (possibly next milestone) Milestone: CKEditor 3.0
Component: General Version:
Keywords: Oracle Review+ Cc: Senthil

Description

To reproduce this issue in IE8/7, please open the attached sample file in IE8/7.

  1. Click the "Click me for multiple times to see the issue" button and you will get an alert as 'instance ready' and press ok. Now you will see the editor's default data.
  1. Repeat the step no.1 again, now click on the editor's content 'Do you see the problem..!!!' but you can't edit/change the content for atleast 2 minutes.

If you don't see the problem, please repeat the steps 1 & 2 again.

To reproduce this issue in Firefox 3.x, please open the attached sample file in FF3.x.

  1. Click the "Click me for multiple times to see the issue" button, now you will not see any data inside the editor's area. Now click on the source control, you will get the alert 'instance ready' and then you will see the data in source mode.


This is a show stopper since the editor is not editable in IE and no data is displayed in FF.

Attachments (6)

replacebycode.html (3.7 KB) - added by Senthil 15 years ago.
3812.patch (4.0 KB) - added by Martin Kou 15 years ago.
3812_2.patch (4.6 KB) - added by Martin Kou 15 years ago.
3812_3.patch (5.1 KB) - added by Martin Kou 15 years ago.
replacebycode.2.html (3.0 KB) - added by Martin Kou 15 years ago.
3812_4.patch (6.8 KB) - added by Martin Kou 15 years ago.

Download all attachments as: .zip

Change History (24)

Changed 15 years ago by Senthil

Attachment: replacebycode.html added

comment:1 Changed 15 years ago by Martin Kou

Owner: set to Martin Kou
Status: newassigned

Changed 15 years ago by Martin Kou

Attachment: 3812.patch added

comment:2 Changed 15 years ago by Martin Kou

Keywords: Review? added

comment:3 Changed 15 years ago by Martin Kou

Keywords: Review? removed

Retracted review request - the problem with IE7/8 is still there.

comment:4 Changed 15 years ago by Martin Kou

Keywords: Review? added

Just did some more tests - turns out IE7 has cached the non-patched code. After deleting all caches and restarted IE7, I'm not having the bug again.

comment:5 Changed 15 years ago by Martin Kou

#3523 marked as dup to this ticket.

comment:6 Changed 15 years ago by Martin Kou

Keywords: Review? removed

Retracting review request - I'll wait for #3827 to get committed first and add the CHANGES.html entry in the next patch.

Changed 15 years ago by Martin Kou

Attachment: 3812_2.patch added

comment:7 Changed 15 years ago by Martin Kou

Keywords: Review? added

comment:8 Changed 15 years ago by Martin Kou

Keywords: Review? removed

Retracted review request - the new loading method never works in Safari.

Changed 15 years ago by Martin Kou

Attachment: 3812_3.patch added

comment:9 Changed 15 years ago by Martin Kou

Keywords: Review? added

Updated patch to make it work under Safari and Opera.

comment:10 Changed 15 years ago by Martin Kou

Keywords: Review? removed

After seeing some test cases from Oracle - the problem is still not fixed in IE7 or IE8. The delay before the editing area becomes editable is still occurring randomly.

comment:11 Changed 15 years ago by Garry Yao

Keywords: Review+ added

comment:12 Changed 15 years ago by Garry Yao

Keywords: Review+ removed

Sorry, didn't get the last comment by Martin, in which case does it fails? It works fine for me in IE7.

comment:13 Changed 15 years ago by Martin Kou

Try Oracle's test case with the new patch on IE7 or IE8 - you'll see that sometimes after pressing the button you will not be able to put focus to inside the editor.

The bug is random is it's definitely a browser bug (and a very nasty one at that). After the button is pressed, the browser's selection model is somehow broken - not only is the things inside the editing area not selectable, everything in the browser window is also not selectable. If you try to click outside of the editing area once and click the editing area again, the caret will come back.

I'm still trying to find a fix for it at the moment.

Changed 15 years ago by Martin Kou

Attachment: replacebycode.2.html added

comment:14 Changed 15 years ago by Martin Kou

The bug in IE7 is found to be caused by the innerHTML assignment in Oracle's sample. Alternatively, it can also be triggered by calling destroy().

I've posted an updated sample where you can reliably reproduce the big in IE7 or 8:

  1. Put replacebycode.2.html in the _samples folder of trunk.
  2. Open it in IE, select some words in the editing area.
  3. Click the button once.
  4. Now you can't select anything in the browser window.

Changed 15 years ago by Martin Kou

Attachment: 3812_4.patch added

comment:15 Changed 15 years ago by Martin Kou

Keywords: Review? added

The culprit of the IE7 or 8 bug is the removal of the editing area - this is done by the innerHTML assignment in Senthil's sample, or, it can be done with destroy() that's within our API.

Senthil's sample is actually doing one thing wrong - he should have called destroy() before creating another editor instance of the same name. This causes the JavaScript error in IE and is not our fault. However, for safety, I've added a check in the editor constructor to check for duplicated instances.

So now the only problem left for us is breaking IE7/8's selection system with destroy() - which is within the scope of our API. The fix to this, is to put the selection back to the parent document without scrolling the window.

comment:16 Changed 15 years ago by Garry Yao

Keywords: Review+ added; Review? removed

Hum...the editor document loading seems much stable now.

comment:17 Changed 15 years ago by Martin Kou

Resolution: fixed
Status: assignedclosed

Fixed with [3794].

Click here for more info about our SVN system.

comment:18 Changed 15 years ago by Frederico Caldeira Knabben

Milestone: CKEditor 3.xCKEditor 3.0
Note: See TracTickets for help on using tickets.
© 2003 – 2022, CKSource sp. z o.o. sp.k. All rights reserved. | Terms of use | Privacy policy